Sideset generators need neighbors #15823
Labels
C: Framework
P: normal
A defect affecting operation with a low possibility of significantly affects.
T: task
An enhancement to the software.
Comments
loganharbour
added
C: Framework
T: task
loganharbour
added a commit
to loganharbour/moose
that referenced
this issue
Sep 17, 2020
loganharbour
added a commit
to loganharbour/moose
that referenced
this issue
Sep 17, 2020
This was referenced Sep 27, 2020
loganharbour
added a commit
to loganharbour/moose
that referenced
this issue
Sep 27, 2020
loganharbour
added a commit
to loganharbour/moose
that referenced
this issue
Sep 27, 2020
loganharbour
added a commit
to loganharbour/moose
that referenced
this issue
Sep 27, 2020
loganharbour
changed the title
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Oct 27, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Oct 27, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Oct 27, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
smharper
pushed a commit
to smharper/moose
that referenced
this issue
Nov 11, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
smharper
pushed a commit
to smharper/moose
that referenced
this issue
Nov 11, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Nov 11, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Nov 11, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Dec 18, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Dec 18, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Dec 18, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Dec 28, 2020
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad
added a commit
to lindsayad/moose
that referenced
this issue
Jan 4, 2021
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
jain651
pushed a commit
to jain651/moose
that referenced
this issue
Apr 19, 2021
We also can signal to the `MeshBase` object if we've done some operation that renders the mesh unprepared. If we do this meticulously then we can trust checks of the `is_prepared` flag to tell us when we need to `prepare_for_use` or not Closes idaholab#15944 idaholab#15936 idaholab#15823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reason
We check
elem->neighbor_ptr(side)inSideSetsGeneratorBaseto exclude element sides that aren't on the boundary. Depending on the status of the input mesh, the neighbors may not be built.Issue found by @gridley.
Design
Call
find_neighbors()on the mesh up front inSideSetsGeneratorBase. Or, come up with a way to set a flag in generators for if the neighbors are needed or not. This issue could easily extend past justSideSetsGeneratorBase.Impact
Will make
SideSetsGeneratorBaseproduce the intended behavior for only adding sidesets to boundary sides.The text was updated successfully, but these errors were encountered: