Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty neighbor lists from FancyExtruderGenerator #15936

Open
smharper opened this issue Oct 13, 2020 · 0 comments
Open

Empty neighbor lists from FancyExtruderGenerator #15936

smharper opened this issue Oct 13, 2020 · 0 comments
Labels
C: Meshing MeshGenerator system, mesh loading P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@smharper
Copy link
Contributor

The mesh output by the FancyExtruderGenerator does not have the neighbors specified for each element. In other words, elem->neighbor_ptr returns nullptr for each side of the new elements.

This information is needed for the sideset generators like SideSetsBetweenSubdomainsGenerator so currently those generators will not work when their input is created by FancyExtruderGenerator.

This needs to be fixed by calling find_neighbors (or prepare_for_use which in turn calls find_neighbors) somewhere along the mesh generation train.
@smharper smharper added the T: defect An anomaly, which is anything that deviates from expectations. label Oct 13, 2020
smharper added a commit to smharper/moose that referenced this issue Oct 13, 2020
@smharper
Find mesh element neighbors in the fancy extruder
d4a53fd 
Refs idaholab#15936
This was referenced Oct 13, 2020
Closed
Closed
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 27, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
8e1045f 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 27, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
c4f5876 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 27, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
ab34a33 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
smharper pushed a commit to smharper/moose that referenced this issue Nov 11, 2020
@lindsayad @smharper
Use MeshBase data to inform us when we should prepare
8f7521d 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
smharper pushed a commit to smharper/moose that referenced this issue Nov 11, 2020
@lindsayad @smharper
Use MeshBase data to inform us when we should prepare
85b3126 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 11, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
5fcb859 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 11, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
a2eb68a 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
@lindsayad lindsayad mentioned this issue Nov 11, 2020
Merged
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 18, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
a130226 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 18, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
630e432 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 18, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
47c333b 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 28, 2020
@lindsayad
Use MeshBase data to inform us when we should prepare
2cffa53 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
lindsayad added a commit to lindsayad/moose that referenced this issue Jan 4, 2021
@lindsayad
Use MeshBase data to inform us when we should prepare
46327bf 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
@aeslaughter aeslaughter added the P: normal A defect affecting operation with a low possibility of significantly affects. label Apr 12, 2021
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@lindsayad
Use MeshBase data to inform us when we should prepare
c9a5fd9 
We also can signal to the `MeshBase` object if we've done some
operation that renders the mesh unprepared. If we do this meticulously
then we can trust checks of the `is_prepared` flag to tell us when we
need to `prepare_for_use` or not

Closes idaholab#15944 idaholab#15936 idaholab#15823
@GiudGiud GiudGiud added the C: Meshing MeshGenerator system, mesh loading label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Meshing MeshGenerator system, mesh loading P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Find mesh element neighbors in the fancy extruder smharper/moose
3 participants
@aeslaughter @smharper @GiudGiud