New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better diagnostic error message when encountering a git-lfs placeholder file #17407
Labels
C: Framework
Good first issue
P: normal
A defect affecting operation with a low possibility of significantly affects.
T: task
An enhancement to the software.
Comments
permcody
added
C: Framework
T: task
An enhancement to the software.
P: normal
A defect affecting operation with a low possibility of significantly affects.
labels
Mar 22, 2021
Yep, this stumped me a while ago. Not a big deal, but confusing. |
permcody
added a commit
to permcody/moose
that referenced
this issue
Apr 2, 2021
permcody
added a commit
to permcody/moose
that referenced
this issue
Apr 2, 2021
permcody
added a commit
to permcody/moose
that referenced
this issue
Apr 8, 2021
aeslaughter
pushed a commit
to aeslaughter/moose
that referenced
this issue
Jun 2, 2021
aeslaughter
pushed a commit
to aeslaughter/moose
that referenced
this issue
Jun 2, 2021
aeslaughter
pushed a commit
to aeslaughter/moose
that referenced
this issue
Jun 2, 2021
Closed by #17489 |
GiudGiud
added a commit
to GiudGiud/moose
that referenced
this issue
Jan 1, 2024
GiudGiud
added a commit
to GiudGiud/moose
that referenced
this issue
Jan 1, 2024
GiudGiud
added a commit
to GiudGiud/moose
that referenced
this issue
Jan 1, 2024
maxnezdyur
pushed a commit
to maxnezdyur/moose
that referenced
this issue
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: Framework
Good first issue
P: normal
A defect affecting operation with a low possibility of significantly affects.
T: task
An enhancement to the software.
Reason
If you checkout a repository on a system that doesn't have git-lfs installed or enabled. You will get placeholder files for any files that are stored in git-lfs data stores. Those files contain plain ASCII text like this:
The problem is that this confuses some of the readers in MOOSE. In particular we sometimes store large mesh files like this in which case the user will get a message like this:
This occurs even if the file is there.
Design
We already have utility routines that check for file readability or writeability before trying to interpret data. We are fairly consistent with calling these. I would propose that we add another utility routine that specifically checks for git-lfs placeholder files that we can call from the readability routine. We could then issue a much more useful error and potentially helpful diagnostic message that could help a user recover without seeking assistance from the developer community.
Impact
None, moderate annoyance.
The text was updated successfully, but these errors were encountered: