Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONDefinitionFormatter updates to improve NEAMS input validation #18639

Closed
brandonlangley opened this issue Aug 19, 2021 · 1 comment · Fixed by #18640
Closed

SONDefinitionFormatter updates to improve NEAMS input validation #18639

brandonlangley opened this issue Aug 19, 2021 · 1 comment · Fixed by #18640
Labels
C: Framework T: task An enhancement to the software.

Comments

@brandonlangley
Copy link
Contributor

Reason

The following SONDefinitionFormatter updates are needed to improve NEAMS Workbench input validation.

  • Add on and off to the ValEnums for Boolean types so that [ true false 1 0 on off ] is the full set of valid values.

  • Remove ValEnums checks from non-TypeBlock declarators to account for [hierarchical/name/notation] mismatches.

  • Fix logic that adds all default TypeBlock parameters to the parent because nlohmann::to_string left quotes on strings.

  • Remove requirement on the Mesh block file parameter added from the default FileMesh TypeBlock so it is optional.

    This is needed since a MeshGenerator internally switches the default FileMesh type to one without a file parameter.

Design

The SONDefinitionFormatter will be updated as described above to address issues in input validation.

New RunApp tests will also be added to check that the generated schema has all the expected updates.

Impact

The reliability of MOOSE application schemas used for NEAMS Workbench input validation will improve.
@brandonlangley brandonlangley added the T: task An enhancement to the software. label Aug 19, 2021
@brandonlangley
Copy link
Contributor Author

@permcody -

I'm planning to open a small PR today with these updates that improve Workbench's input validation of MOOSE apps.

Could you add this to the FY 21 NEAMS Multiphysics Technical Assistance Support Project?

brandonlangley pushed a commit to brandonlangley/moose that referenced this issue Aug 19, 2021
Update SONDefinitionFormatter for NEAMS input validation improvements
be34683 
 - Add 'on' and 'off' to the ValEnums valid choices for Boolean types
 - Remove ValEnums checks on all block declarators for non-TypeBlocks
 - Fix logic that promotes default TypeBlock parameters to the parent
 - Make 'file' parameter optional when promoted from FileMesh to Mesh

Closes idaholab#18639
@brandonlangley brandonlangley mentioned this issue Aug 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SONDefinitionFormatter for NEAMS input validation brandonlangley/moose
2 participants
@brandonlangley @loganharbour