Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to install examples or other directories #19022

Closed
joshuahansel opened this issue Oct 6, 2021 · 2 comments · Fixed by #20585
Closed

Add the ability to install examples or other directories #19022

joshuahansel opened this issue Oct 6, 2021 · 2 comments · Fixed by #20585
Labels
T: task An enhancement to the software.
Projects
FY22 NEAMS MP - TA Support

Comments

@joshuahansel
Copy link
Contributor

joshuahansel commented Oct 6, 2021 •
edited by rwcarlsen

Reason

Binary-only users for applications benefit from having access to non-source content other than the contents of test/tests.

Design

This would allow application developers to specify their own directories that can be installed in addition to test/tests. Add a makefile variable that apps can set in their own makefiles that contains a list of zero or more additional directories to be treated like test/tests during the install process - i.e. copied wholesale into [PREFIX]/share/[appname]/[dirname].

Impact

This will add new capability and shouldn't affect existing capability.
@joshuahansel joshuahansel added the T: task An enhancement to the software. label Oct 6, 2021
@joshuahansel
Copy link
Contributor Author

@rwcarlsen Feel free to beef up the issue description - I'm pretty ignorant on this topic.

@lindsayad: @permcody suggested I ask you to tag this issue in the MOOSE TA support task.

@lindsayad lindsayad added this to To do in FY22 NEAMS MP - TA Support via automation Oct 6, 2021
@lindsayad
Copy link
Member

done!

permcody added a commit to permcody/moose that referenced this issue Feb 18, 2022
@permcody
Generalizing the install and run logic to handle more than just "tests"
ec125fa 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Feb 18, 2022
@permcody
Makefile changes to support multiple installable directories
0cf737d 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Feb 21, 2022
@permcody
Generalizing the install and run logic to handle more than just "tests"
2859121 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Feb 21, 2022
@permcody
Makefile changes to support multiple installable directories
8bb357a 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 3, 2022
@permcody
Fixing up tests
7b76d68 
Getting rid of assumptions in tests that rely on the file structure further up than the copy point. This
includes the relative location of the executable.

Also removing the empty executable option. While this isn't an unreasonable test, we don't have a good
capability today to run a test that relies on a relative path outside of the installed tree. We may re-add
this capability at a later date. By switching all the useability tests back to RunApp we can't control the
CLI arguments that are passed to the application, invalidating the need for that test.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 3, 2022
@permcody
Generalizing the install and run logic to handle more than just "tests"
bfb6728 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 3, 2022
@permcody
Makefile changes to support multiple installable directories
b44e860 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 3, 2022
@permcody
Fixing up tests
a13bb7c 
Getting rid of assumptions in tests that rely on the file structure further up than the copy point. This
includes the relative location of the executable.

Also removing the empty executable option. While this isn't an unreasonable test, we don't have a good
capability today to run a test that relies on a relative path outside of the installed tree. We may re-add
this capability at a later date. By switching all the useability tests back to RunApp we can't control the
CLI arguments that are passed to the application, invalidating the need for that test.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 8, 2022
@permcody @loganharbour
Generalizing the install and run logic to handle more than just "tests"
9df7539 
refs idaholab#19022

Apply suggestions from code review

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
permcody added a commit to permcody/moose that referenced this issue Mar 8, 2022
@permcody
Makefile changes to support multiple installable directories
98fd6b8 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 8, 2022
@permcody
Fixing up tests
b3c2569 
Getting rid of assumptions in tests that rely on the file structure further up than the copy point. This
includes the relative location of the executable.

Also removing the empty executable option. While this isn't an unreasonable test, we don't have a good
capability today to run a test that relies on a relative path outside of the installed tree. We may re-add
this capability at a later date. By switching all the useability tests back to RunApp we can't control the
CLI arguments that are passed to the application, invalidating the need for that test.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 9, 2022
@permcody
Build system testing and documentation
ffad367 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 10, 2022
@permcody @loganharbour
Generalizing the install and run logic to handle more than just "tests"
c1673f7 
refs idaholab#19022

Apply suggestions from code review

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
permcody added a commit to permcody/moose that referenced this issue Mar 10, 2022
@permcody
Makefile changes to support multiple installable directories
bfe72ec 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 10, 2022
@permcody
Fixing up tests
881d13f 
Getting rid of assumptions in tests that rely on the file structure further up than the copy point. This
includes the relative location of the executable.

Also removing the empty executable option. While this isn't an unreasonable test, we don't have a good
capability today to run a test that relies on a relative path outside of the installed tree. We may re-add
this capability at a later date. By switching all the useability tests back to RunApp we can't control the
CLI arguments that are passed to the application, invalidating the need for that test.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 10, 2022
@permcody
Build system testing and documentation
a924a1d 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 10, 2022
@permcody
Build system testing and documentation
04d030d 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 11, 2022
@permcody
Build system testing and documentation
5f4513c 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 11, 2022
@permcody
Build system testing and documentation
0820de0 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 12, 2022
@permcody
Make copy and run commands more robust for parallel launches
792af5d 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 12, 2022
@permcody
Fixing up tests
7059a08 
Getting rid of assumptions in tests that rely on the file structure further up than the copy point. This
includes the relative location of the executable.

Also removing the empty executable option. While this isn't an unreasonable test, we don't have a good
capability today to run a test that relies on a relative path outside of the installed tree. We may re-add
this capability at a later date. By switching all the useability tests back to RunApp we can't control the
CLI arguments that are passed to the application, invalidating the need for that test.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 12, 2022
@permcody
Build system testing and documentation
26264f9 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 12, 2022
@permcody
Make copy and run commands more robust for parallel launches
bb51e12 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 13, 2022
@permcody
Better default for INSTALLABLE_DIRS
c4a31c6 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 13, 2022
@permcody
Drop the Makefile Loop
efee3ae 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 13, 2022
@permcody
Drop the Makefile Loop
335bc65 
refs idaholab#19022
FY22 NEAMS MP - TA Support automation moved this from To do to Done Mar 17, 2022
permcody added a commit to permcody/moose that referenced this issue Mar 18, 2022
@permcody
Continue Cleanup of install tests
307a666 
1) Removing old --copy-tests and --tests options
2) Getting rid of convoluted logic to fun tests in system installed location
3) Introducing the first C++17 filesystem syntax

refs idaholab#19022
@permcody permcody mentioned this issue Mar 18, 2022
Merged
permcody added a commit to permcody/moose that referenced this issue Mar 18, 2022
@permcody
Continue Cleanup of install tests
4dade4a 
1) Removing old --copy-tests and --tests options
2) Getting rid of convoluted logic to fun tests in system installed location
3) Introducing the first C++17 filesystem syntax

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 21, 2022
@permcody
Dropping first C++17 include :(
b80195b 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 23, 2022
@permcody
INSTALLABLE_DIRS default fix
0b52494 
INSTALLABLE_DIRS is not defined in any .mk file. It does not need to be
stored on the Makefile stack. Also the test needs to account fo undefined
variables, not just empty variables.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 23, 2022
@permcody
INSTALLABLE_DIRS default fix
dc1cee4 
INSTALLABLE_DIRS is not defined in any .mk file. It does not need to be
stored on the Makefile stack. Also the test needs to account fo undefined
variables, not just empty variables.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 28, 2022
@permcody
Add a --show-copyable-inputs CLI flag
7fe2beb 
The --show-copyable-inputs flag shows a list of installable directories
to end users in case there are several or the lists are complicated.

Also applied some drive-by const-correctness in a few related methods.

refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @loganharbour @grmnptr
Generalizing the install and run logic to handle more than just "tests"
c55bd87 
refs idaholab#19022

Apply suggestions from code review

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Makefile changes to support multiple installable directories
70420ba 
refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Fixing up tests
bd4b55d 
Getting rid of assumptions in tests that rely on the file structure further up than the copy point. This
includes the relative location of the executable.

Also removing the empty executable option. While this isn't an unreasonable test, we don't have a good
capability today to run a test that relies on a relative path outside of the installed tree. We may re-add
this capability at a later date. By switching all the useability tests back to RunApp we can't control the
CLI arguments that are passed to the application, invalidating the need for that test.

refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Build system testing and documentation
1968a2e 
refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Make copy and run commands more robust for parallel launches
18b992c 
refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Better default for INSTALLABLE_DIRS
a72d253 
refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Drop the Makefile Loop
16abc72 
refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Feel like I'm getting into hacking territory
0975e7d 
It turns out that there are some baked in assumptions of where the App is located
relative to the testroot. There are some nasty hacks to locate it in a normal
installation location, but this doesn't work if you install elsewhere (like we have
to for the test). In order to get the TestHarness to behave, it's easiest to just
link the executable to the fake test hierarchy. This part isn't a hack ;)

Next Problem, the TestHarness currently checks for the working directory to exist
in the Runnable phase, which occurs asyncronously to the scheduled launch of the
test. This is a no go, since we are trying to copy the directory structure in the test
so it won't exist for latter tests. So... I moved the working directory check to
the place where we actually launch the test. This would be OK, but apparently there
are other assumptions baked into the Job class. I had to start/stop the timer to
avoid an index out of range.

Now the tests are running properly.

refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@tophmatthews @grmnptr
Don't do valgrind for command option tests. Ref idaholab#19022
933ab1c
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Make make_install tests more robust
8d42023 
1) Moving the copied test structure outside of the main test root. This prevents any side effects
   from an unexpected termination or any other failure of the tear down step followed by a subsequent
   relaunch of the test suite.
2) Removing the method=opt restriction, which triggered the original failure by causing the tear down
   step to be skipped during a normal test run. Instead I'm just going to link all versions of the
   binary into the installed directory and allow this to run in all modes.

closes idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Continue Cleanup of install tests
3b8b4ea 
1) Removing old --copy-tests and --tests options
2) Getting rid of convoluted logic to fun tests in system installed location
3) Introducing the first C++17 filesystem syntax

refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
Dropping first C++17 include :(
9a18916 
refs idaholab#19022
grmnptr pushed a commit to grmnptr/moose that referenced this issue Mar 29, 2022
@permcody @grmnptr
INSTALLABLE_DIRS default fix
d8048ba 
INSTALLABLE_DIRS is not defined in any .mk file. It does not need to be
stored on the Makefile stack. Also the test needs to account fo undefined
variables, not just empty variables.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 30, 2022
@permcody
Add a --show-copyable-inputs CLI flag
e0bdbf0 
The --show-copyable-inputs flag shows a list of installable directories
to end users in case there are several or the lists are complicated.

Also applied some drive-by const-correctness in a few related methods.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 30, 2022
@permcody
Add a --show-copyable-inputs CLI flag
c5a86bd 
The --show-copyable-inputs flag shows a list of installable directories
to end users in case there are several or the lists are complicated.

Also applied some drive-by const-correctness in a few related methods.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Mar 31, 2022
@permcody
Add a --show-copyable-inputs CLI flag
12d2e18 
The --show-copyable-inputs flag shows a list of installable directories
to end users in case there are several or the lists are complicated.

Also applied some drive-by const-correctness in a few related methods.

refs idaholab#19022
permcody added a commit that referenced this issue Apr 1, 2022
@permcody
Add output to the CheckFiles Tester so we can see what's going on
4cc739d 
refs #19022
permcody added a commit to permcody/moose that referenced this issue Apr 4, 2022
@permcody
Add a --show-copyable-inputs CLI flag
ce067fe 
The --show-copyable-inputs flag shows a list of installable directories
to end users in case there are several or the lists are complicated.

Also applied some drive-by const-correctness in a few related methods.

refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Apr 4, 2022
@permcody
Add output to the CheckFiles Tester so we can see what's going on
94e1331 
refs idaholab#19022
permcody added a commit to permcody/moose that referenced this issue Apr 4, 2022
@permcody
Switching to Rsync is the only sane way to work across systems
53c7f5f 
refs idaholab#19022
@loganharbour loganharbour mentioned this issue Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: task An enhancement to the software.
Projects
No open projects
FY22 NEAMS MP - TA Support
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make make_install tests more robust permcody/moose
2 participants
@lindsayad @joshuahansel