Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an --app command line parameter #20062

Closed
lindsayad opened this issue Jan 17, 2022 · 0 comments · Fixed by #20066
Closed

Create an --app command line parameter #20062

lindsayad opened this issue Jan 17, 2022 · 0 comments · Fixed by #20066
Assignees
@lindsayad
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
FY22 NEAMS MP - TA Support

Comments

@lindsayad
Copy link
Member

Reason

Some applications actions and App classes do not play nicely with others. We'd like to create an --app cli option such that the application used to run the (main) input file can be chosen from any of the applications registered to the AppFactory the executable application. This would enable, for example, explicitly using the SamApp to run a SAM input from a blue_crab-* executable.

Design

Leverage the application registry which holds the applications the current executable recognizes. Make AppFactory::createAppShared's first argument a default_app parameter which is used if the --app parameter is not provided.

Impact

More flexibility for our "combined" applications
@lindsayad lindsayad added the T: task An enhancement to the software. label Jan 17, 2022
@lindsayad lindsayad self-assigned this Jan 17, 2022
@lindsayad lindsayad added this to To do in FY22 NEAMS MP - TA Support via automation Jan 17, 2022
@lindsayad lindsayad added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. labels Jan 17, 2022
lindsayad added a commit to lindsayad/moose that referenced this issue Jan 17, 2022
@lindsayad
Add option for specifying specific application for input run
0a13b20 
Closes idaholab#20062
@lindsayad lindsayad mentioned this issue Jan 17, 2022
Merged
lindsayad added a commit to lindsayad/moose that referenced this issue Jan 18, 2022
@lindsayad
Add option for specifying specific application for input run
e96e4e9 
Closes idaholab#20062
lindsayad added a commit to lindsayad/moose that referenced this issue Jan 20, 2022
@lindsayad
Add option for specifying specific application for input run
c36faa0 
Closes idaholab#20062
lindsayad added a commit to lindsayad/moose that referenced this issue Jan 20, 2022
@lindsayad
Add option for specifying specific application for input run
2ce6496 
Closes idaholab#20062
FY22 NEAMS MP - TA Support automation moved this from To do to Done Jan 24, 2022
reverendbedford pushed a commit to reverendbedford/moose that referenced this issue Jan 27, 2022
@lindsayad @reverendbedford
Add option for specifying specific application for input run
b610987 
Closes idaholab#20062
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 9, 2022
@GiudGiud
Add clearer error message for syntax issues when running the wrong ap…
cdf256b 
…p, refs idaholab#20062
@GiudGiud GiudGiud mentioned this issue Oct 9, 2022
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 11, 2022
@GiudGiud
Add test for wrong syntax of action, refs idaholab#20062
9c991c9 
Format tests for misc/check_error
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 11, 2022
@GiudGiud
Add test for wrong syntax of action, refs idaholab#20062
51015a3 
Format tests for misc/check_error
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 11, 2022
@GiudGiud
Add test for wrong syntax of action, refs idaholab#20062
c23c7a9 
Format tests for misc/check_error
@lindsayad lindsayad mentioned this issue Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindsayad lindsayad

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
No open projects
FY22 NEAMS MP - TA Support
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option for specifying specific application for input run lindsayad/moose
1 participant
@lindsayad