Add option for specifying specific application for input run #20066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsayad
force-pushed
the
app-param-20062
branch
from
0a13b20
to
e96e4e9
Compare
|
Job Documentation on 636019d wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on 636019d wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReportsThis comment will be updated on new commits. |
||||||||||||||||||||||||||
loganharbour
previously approved these changes
Jan 19, 2022
lindsayad
force-pushed
the
app-param-20062
branch
from
e96e4e9
to
74e935b
Compare
I personally have never run across this error in any real user experiences, so I question whether it has any real value. Moreover this error check prevents executing a specific application of a "combined" application like blue_crab because the blue_crab executable contains registry entries for all the objects compiled into the executable (or more appropriately all the objects in the executable with register calls in their .C file) yet we only `registerAll` for the specific application we are executing. So if specifically running Griffin for example, we get tons of errors about labels/applications: Bison, SAM, Pronghorn, etc.
lindsayad
force-pushed
the
app-param-20062
branch
from
74e935b
to
636019d
Compare
|
@loganharbour this is ready to review. If you approve, I'll wait to merge until we've worked out the |
loganharbour
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20062