Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face Variable Support #20191

Closed
permcody opened this issue Feb 1, 2022 · 2 comments
Closed

Face Variable Support #20191

permcody opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@permcody
Copy link
Member

permcody commented Feb 1, 2022

Reason

The development and support of lower-dimensional variables “face variables” in support of high-fidelity reactor analysis in Griffin.

Design

This needs to be implemented in both the nonlinear and auxiliary systems.

Impact

FY22 CRAB WP Task

@permcody permcody added the T: task An enhancement to the software. label Feb 1, 2022
@permcody permcody added this to To do in FY22 NEAMS MP - CRAB via automation Feb 1, 2022
@roystgnr roystgnr self-assigned this Feb 1, 2022
@roystgnr
Copy link
Contributor

roystgnr commented Feb 1, 2022

Current status:

libMesh has face variables available, with FE type SIDE_HIERARCHIC, but not for all geometric element types and orders. Currently we support face variables in 1D, in 2D, and on Hexes in 3D for p=0,1,2.

Support for cubic and higher face variables on Hexes is supposed to be working, but isn't passing tests; I probably have something wrong somewhere in the shape orientation code for those.

Support for face variables on Pyramids is partly done in a branch, but I had to put it down for more urgent tasks before I got it working. Hopefully once I'm back at it, it won't take too much longer to finish. Worst-case scenario: if I really get stuck here, I could just merge lower-order variables (IIRC p=0 is already working in the branch, and is all many of our users need ASAP) right away and fix up the higher-order shapes later.

Support for face variables on Prisms isn't started yet. The underlying work (Tri7 HIERARCHIC support) is shared with Pyramids, though, so hopefully it won't take as much work as they have.

Support for invoking these variables in Moose isn't there yet, but that'll be a fairly tiny shim. I'll work at that (plus a couple tests) next - it'll be easy and it'll enable Hex+2D work immediately, and if I'm missing something and it's not easy then it'll be best if we learn that immediately.

roystgnr added a commit to roystgnr/moose that referenced this issue Feb 8, 2022
shikhar413 pushed a commit to shikhar413/moose that referenced this issue Feb 14, 2022
roystgnr added a commit to roystgnr/moose that referenced this issue Sep 27, 2022
roystgnr added a commit to roystgnr/moose that referenced this issue Sep 28, 2022
roystgnr added a commit to roystgnr/moose that referenced this issue Oct 6, 2022
roystgnr added a commit to roystgnr/moose that referenced this issue Oct 6, 2022
roystgnr added a commit to roystgnr/moose that referenced this issue Oct 6, 2022
roystgnr added a commit to roystgnr/moose that referenced this issue Nov 14, 2022
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 4, 2023
@roystgnr
Copy link
Contributor

roystgnr commented Jan 5, 2023

This has been working for a while for 2D+Hexes+Prisms, which AFAIK is everything Griffin needs. The remaining lack of Pyramid support bothers me greatly on an emotional level, and I'll get around to completing that sooner or later, but it's not really worthy of keeping a MOOSE issue open.

@roystgnr roystgnr closed this as completed Jan 5, 2023
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
No open projects
Development

No branches or pull requests

2 participants