Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable advected schemes other than upwind/average for INSFV/WCNSFV #20493

Closed
lindsayad opened this issue Mar 8, 2022 · 0 comments · Fixed by #20504
Closed

Enable advected schemes other than upwind/average for INSFV/WCNSFV #20493

lindsayad opened this issue Mar 8, 2022 · 0 comments · Fixed by #20504
Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module T: task An enhancement to the software.

Comments

@lindsayad
Copy link
Member

Reason

We have quite a few limiter options for CNSFV but thus far we've stuck with just upwind and averaging for advected quantities in our RC INSFV/WCNSFV implementation. I would like to try, at a minimum, second-order upwind on @sokyay's cask problem to see whether I can match FE in terms of accuracy and robustness.

Design

Not quite sure yet. Call through our existing Limiter system hopefully

Impact

Way more advection schemes at user's disposal. To be a fully-featured CFD code we can't just offer first-order upwind and average.
@lindsayad lindsayad added T: task An enhancement to the software. C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module labels Mar 8, 2022
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 8, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
1b5d4eb 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 8, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
1a4f3bb 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 8, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
1aefe1a 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 8, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
696d353 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 9, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
34a8b52 
Closes idaholab#20493
@lindsayad lindsayad mentioned this issue Mar 9, 2022
Merged
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 11, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
723788c 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 21, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
b868c64 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 23, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
7dbdf5f 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Mar 24, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
e814568 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 4, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
55133c4 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 4, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
4f1d6bb 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 6, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
706e681 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 11, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
bf26bf7 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 13, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
924df60 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 15, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
c1d7291 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 20, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
4178766 
Closes idaholab#20493
lindsayad added a commit to lindsayad/moose that referenced this issue Apr 25, 2022
@lindsayad
Implement generalized advection schemes for RC NS implementation
1f82603 
Closes idaholab#20493
GiudGiud added a commit to GiudGiud/moose that referenced this issue Apr 26, 2022
@GiudGiud
Adapt to changes in FV arguments, refs idaholab#20493
4b79aa1
GiudGiud added a commit to GiudGiud/moose that referenced this issue Apr 26, 2022
@GiudGiud
Adapt to changes in FV arguments, refs idaholab#20493
7add8ac
grmnptr pushed a commit to grmnptr/moose that referenced this issue May 3, 2022
@lindsayad @grmnptr
Implement generalized advection schemes for RC NS implementation
f113f2f 
Closes idaholab#20493
grmnptr pushed a commit to grmnptr/moose that referenced this issue May 3, 2022
@GiudGiud @grmnptr
Adapt to changes in FV arguments, refs idaholab#20493
e3aa5bb
grmnptr pushed a commit to grmnptr/moose that referenced this issue May 3, 2022
@lindsayad @grmnptr
Implement generalized advection schemes for RC NS implementation
0474170 
Closes idaholab#20493
grmnptr pushed a commit to grmnptr/moose that referenced this issue May 3, 2022
@GiudGiud @grmnptr
Adapt to changes in FV arguments, refs idaholab#20493
60c4ed1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement generalized advection schemes for RC NS implementation lindsayad/moose
1 participant
@lindsayad