Implement generalized advection schemes for RC NS implementation #20504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation on 2648854 wanted to post the following: View the site here This comment will be updated on new commits. |
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
from
34a8b52
to
b868c64
Compare
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
from
b868c64
to
7dbdf5f
Compare
lindsayad
commented
Mar 24, 2022
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
from
ad3e8a9
to
b0b6772
Compare
|
Job Coverage on 2648854 wanted to post the following: Framework coverage
Modules coverageNavier stokes
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
4 times, most recently
from
be84f84
to
07bd2b7
Compare
|
The cool thing about using atomic interpolations at the inlet with Dirichlet BCs is that we no longer need flux BCs to do coupling with SAM. |
lindsayad
changed the title
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
2 times, most recently
from
2b37c7f
to
e3cf758
Compare
lindsayad
changed the title
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
6 times, most recently
from
8a977ee
to
1f15e0c
Compare
Fits with the philosophy of put your code where you use it which the new coverage testing encourages and which I love
- Have PINSFVMassAdvection inherit from INSFVMassAdvection - Add epsilon virtual method to INSFVMomentumAdvection
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
5 times, most recently
from
f62ccec
to
34ffd12
Compare
…ights This forces atomic evaluation of components of aggregate functors (such as functor material properties), which allows direct substitution of Dirichlet information when component(s) are variables. This allows more accurate setting of incoming fluxes This dramatically improves our results on skewed meshes, as demonstrated on one of Sinan's cask setups This prevents zero mixing lengths and zero eddy viscosity. Additionally: change default for fv = true variable two-term boundary expansion to `true`. If users select finite volume variables through the `fv = true` flag as opposed to specifying `type = MooseVariableFVReal`, then we need to make sure they get the same default for two term boundary expansion, which is `true`. Except when doing vertex based interpolation. This necessitated adding a special handler in `Moose::FV::interpolate(FunctorBase, FaceArg)` as the `Moose::FV::linearInterpolation(FunctorBase, FaceArg)` function is the only global function that currently handles skewness correction correctly. I decided to make this change for MooseVariableFV::evaluate(FaceArg) after trigging a debug mode assertion when interpolating passive scalars in the 2d-mixing-length test in INSFV. When I had changed the scalar field advection kernel to functor evaluation based off Face arguments, then I actually changed the evaluation behind-the-scenes from upwind for this test to central-differencing. This is because all other face evaluations in INSFV (I think) go through functor material properties and end up using the global `Moose::FV::interpolate` functions which apply the correct interpolation/limiting method supplies by the user. However, prior to this commit variable evaluations did their own handling without dispatching to the global `Moose::FV::interpolate` functions and always applied some form of central-differencing on internal faces. That is now changed so the mixing length test is back to upwinding its passive scalar transport, which necessitated another re-golding - We make sure to extend the change in advection kernel evaluation at boundaries to the VolumetricFlowRate postprocessor. - Evaluation of incoming momentum flux is more accurate with these changes which puts more tax on the wall-function tests. This is because before when we upwinded the momentum at the boundaries we would actually apply positive y-velocities at the incoming face near the wall which led to a non-monotone y-velocity profile near the wall moving from the inlet down the channel. Now we actually apply the 0 y-velocity at the inlet face which makes for a more challenging solve due to the large gradient in y-velocity the solver wants to impose due to the large viscous forces. (This is my hypothesis anyway). To make things easier on the solver, I've reduced the Reynolds number. Note that if you psuedo-step to steady-state, convergence is excellent with the original Reynolds number - Created a couple of global functions for help in creating interpolation parameters and for using those parameters to set advection and velocity interpolation object data members - Limiter/interpolation coverage enhancements - An additional change in this commit is making PINSFVEnergyAdvection a trivial derivative of INSFVEnergyAdvection such that we reuse all the code, e.g. computeQpResidual - Test vector and array functor material properties - Allow construction of VectorCompositeFunctor with 1-3 functors - Convert mixing length tests into transient tests Refs joe61vette/ASP#8 temp
lindsayad
force-pushed
the
general-advection-schemes-20493
branch
from
34ffd12
to
2648854
Compare
|
Ok @GiudGiud I think this should be good again |
GiudGiud
approved these changes
Apr 26, 2022
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Apr 26, 2022
For higher-order advection schemes we need two layers. References distributed mesh failures on next post idaholab#20504
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Apr 27, 2022
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 3, 2022
Refs idaholab#20504 and CIVET failure https://civet.inl.gov/job/1031891/
grmnptr
pushed a commit
to grmnptr/moose
that referenced
this pull request
May 3, 2022
For higher-order advection schemes we need two layers. References distributed mesh failures on next post idaholab#20504
grmnptr
pushed a commit
to grmnptr/moose
that referenced
this pull request
May 3, 2022
grmnptr
pushed a commit
to grmnptr/moose
that referenced
this pull request
May 3, 2022
For higher-order advection schemes we need two layers. References distributed mesh failures on next post idaholab#20504
grmnptr
pushed a commit
to grmnptr/moose
that referenced
this pull request
May 3, 2022
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 3, 2022
Per Peter, QUICK is not TVD after rF=5 and SOU fails beyond rF=2. Consequently, a coefficient of 1e6 is pretty ludicrous. Cutting to 1e3 seems to make nonlinear convergence quite a bit better for a lid problem with symmetry in x-velocity about the vertical center-line. Refs advection sheme test case introduced in idaholab#20504
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 3, 2022
Per Peter, QUICK is not TVD after rF=5 and SOU fails beyond rF=2. Consequently, a coefficient of 1e6 is pretty ludicrous. Cutting to 1e3 seems to make nonlinear convergence quite a bit better for a lid problem with symmetry in x-velocity about the vertical center-line. Refs advection sheme test case introduced in idaholab#20504
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 10, 2022
Per Peter, QUICK is not TVD after rF=5 and SOU fails beyond rF=2. Consequently, a coefficient of 1e6 is pretty ludicrous. Cutting to 1e3 seems to make nonlinear convergence quite a bit better for a lid problem with symmetry in x-velocity about the vertical center-line. Refs advection sheme test case introduced in idaholab#20504
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
May 10, 2022
Per Peter, QUICK is not TVD after rF=5 and SOU fails beyond rF=2. Consequently, a coefficient of 1e6 is pretty ludicrous. Cutting to 1e3 seems to make nonlinear convergence quite a bit better for a lid problem with symmetry in x-velocity about the vertical center-line. Refs advection sheme test case introduced in idaholab#20504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20493
@grmnptr if we want to make this happen, I'd appreciate your thoughts on how to best incorporate skew into this