Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint: no log or warning on conflict between restart and initial conditions #21423

Closed
GiudGiud opened this issue Jun 27, 2022 · 0 comments · Fixed by #25421
Closed

Checkpoint: no log or warning on conflict between restart and initial conditions #21423

GiudGiud opened this issue Jun 27, 2022 · 0 comments · Fixed by #25421
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

Bug Description

When using the checkpoint restart system, the initial conditions are likely not to be used. There is nothing telling the user that they are used anyway

Steps to Reproduce

Do a restart from checkpoint simulation, forget to delete your ICs

Impact

Wasted time on code coupling work
@GiudGiud GiudGiud added C: Framework T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Jun 27, 2022
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 4, 2023
@GiudGiud
Dont allow checkpoint recovery/restart and exodus restart at the same…
ae8f8e3 
… time, refs idaholab#21423
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 4, 2023
@GiudGiud
Dont allow checkpoint/exodus restart and initial conditions at the sa…
bcb764c 
…me time

Unless user says it s fine
 refs idaholab#21423
@GiudGiud GiudGiud mentioned this issue Sep 4, 2023
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 4, 2023
@GiudGiud
Add boolean authorizing ICs and restart to tests in the modules that …
bde9502 
…are doing both

 refs idaholab#21423
The output of these tests (gold file) includes both the ICs and the restart, which is odd in general, and sometimes what someone would want to do

Fix some issues in porous flow (missing number)
Update a deprecated FP, format inputs on save
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 4, 2023
@GiudGiud
Add boolean authorizing ICs and restart to tests in the modules that …
6d62d99 
…are doing both

 refs idaholab#21423
The output of these tests (gold file) includes both the ICs and the restart, which is odd in general, and sometimes what someone would want to do

Fix some issues in porous flow (missing number)
Update a deprecated FP, format inputs on save
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 5, 2023
@GiudGiud
Dont allow checkpoint recovery/restart and exodus restart at the same…
9539914 
… time, refs idaholab#21423
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 5, 2023
@GiudGiud
Dont allow checkpoint/exodus restart and initial conditions at the sa…
400fe18 
…me time

Unless user says it s fine
 refs idaholab#21423
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 5, 2023
@GiudGiud
Add boolean authorizing ICs and restart to tests in the modules that …
4ebc196 
…are doing both

 refs idaholab#21423
The output of these tests (gold file) includes both the ICs and the restart, which is odd in general, and sometimes what someone would want to do

Fix some issues in porous flow (missing number)
Update a deprecated FP, format inputs on save
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 7, 2023
@GiudGiud
Disallow by default ICs on restart for restarted variables, clsoes id…
71e2677 
…aholab#21423
@GiudGiud GiudGiud mentioned this issue Sep 7, 2023
Merged
8 tasks
GiudGiud added a commit to idaholab/virtual_test_bed that referenced this issue Sep 26, 2023
@GiudGiud
Allow initial conditions with restart for MSFR input, refs idaholab/m…
6324c9c 
…oose#21423
@GiudGiud GiudGiud mentioned this issue Sep 26, 2023
Merged
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @oanaoana
Dont allow checkpoint recovery/restart and exodus restart at the same…
d6c6423 
… time, refs idaholab#21423
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @oanaoana
Dont allow checkpoint/exodus restart and initial conditions at the sa…
37fc72e 
…me time

Unless user says it s fine
 refs idaholab#21423
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @oanaoana
Add boolean authorizing ICs and restart to tests in the modules that …
638cf32 
…are doing both

 refs idaholab#21423
The output of these tests (gold file) includes both the ICs and the restart, which is odd in general, and sometimes what someone would want to do

Fix some issues in porous flow (missing number)
Update a deprecated FP, format inputs on save
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @oanaoana
Disallow by default ICs on restart for restarted variables, clsoes id…
9801fb5 
…aholab#21423
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
@GiudGiud @oanaoana
Dont allow checkpoint recovery/restart and exodus restart at the same…
57779f0 
… time, refs idaholab#21423
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
@GiudGiud @oanaoana
Dont allow checkpoint/exodus restart and initial conditions at the sa…
8bc315b 
…me time

Unless user says it s fine
 refs idaholab#21423
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
@GiudGiud @oanaoana
Add boolean authorizing ICs and restart to tests in the modules that …
269f41d 
…are doing both

 refs idaholab#21423
The output of these tests (gold file) includes both the ICs and the restart, which is odd in general, and sometimes what someone would want to do

Fix some issues in porous flow (missing number)
Update a deprecated FP, format inputs on save
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
@GiudGiud @oanaoana
Disallow by default ICs on restart for restarted variables, clsoes id…
297046b 
…aholab#21423
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 27, 2023
@GiudGiud
Add more details to Checkpoin t restart + IC error
112e5cb 
refs idaholab#21423
pbehne pushed a commit to pbehne/moose that referenced this issue Dec 1, 2023
@GiudGiud @pbehne
Add more details to Checkpoin t restart + IC error
15ec072 
refs idaholab#21423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow by default ICs on restart for restarted variables GiudGiud/moose
1 participant
@GiudGiud