Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow by default ICs on restart for restarted variables #25421

Merged
merged 1 commit into from Sep 25, 2023

Conversation

@GiudGiud GiudGiud self-assigned this Sep 7, 2023
@moosebuild
Copy link
Contributor

Job Documentation on 71e2677 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Sep 7, 2023

Job Coverage on 71e2677 wanted to post the following:

Framework coverage

071e84 #25421 71e267
Total Total +/- New
Rate 85.68% 85.68% - 100.00%
Hits 91550 91550 - 1
Misses 15305 15305 - 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

All jobs on 71e2677 : invalidated by @GiudGiud

patches merged

@moosebuild
Copy link
Contributor

Job Controlled app tests on 71e2677 : invalidated by @GiudGiud

new BC patch merged

@GiudGiud GiudGiud marked this pull request as ready for review September 20, 2023 23:57
@moosebuild
Copy link
Contributor

Job Controlled app tests on 71e2677 : invalidated by @GiudGiud

@GiudGiud
Copy link
Contributor Author

All patches have been merged, good to go

@moosebuild
Copy link
Contributor

Job Controlled app tests on 71e2677 : invalidated by @lindsayad

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as subchannel passes

@GiudGiud
Copy link
Contributor Author

Passes now. Thanks for the review!

@GiudGiud GiudGiud merged commit fe7907a into idaholab:next Sep 25, 2023
44 of 45 checks passed
@GiudGiud GiudGiud deleted the PR_ics2 branch September 25, 2023 19:04
@YaqiWang
Copy link
Contributor

@GiudGiud heavy tests in Griffin: https://civet.inl.gov/job/1790464/ need to be fixed for this change. There is also one VTB griffin test.

@GiudGiud
Copy link
Contributor Author

Patches are up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint: no log or warning on conflict between restart and initial conditions
4 participants