Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for optional coupling #2358

Closed
friedmud opened this issue Feb 14, 2014 · 8 comments
Closed

Default value for optional coupling #2358

friedmud opened this issue Feb 14, 2014 · 8 comments
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@friedmud
Copy link
Contributor

We've talked in the past about doing something better for optional coupling (like #1483 ) - but I think I have a better idea.

Right now we provide a default value for all other kinds of parameters... why not for optional coupling? So it would look like this:

params.addCoupledVar("name", 3.0, "Documentation");

Then - if that coupling is not set up in the input file then that "variable" will automatically get a value of 3. So in the constructor you would just do this:

_var_value(coupledValue("name"))

And it would either give you the value of the coupled variable or 3....

We could either deprecate the old syntax ( addCoupledVar("name", "Docs") ) or we could leave it and it just implies 0.

@friedmud
Copy link
Contributor Author

In b9491b2:

Initial commit of optional coupling refs #2358

@friedmud
Copy link
Contributor Author

In a3b2947:

guard a libmesh call better refs #2358

@permcody
Copy link
Member

In b0eeeed:

Fix memory leaks... refs #2358

@permcody
Copy link
Member

In b1baaf7:

Initialize _max_qps - refs #2358

@permcody
Copy link
Member

In f3b4be0:

More bugs! (Were you a little bit too involved with Game of Thrones?!) - refs #2358

@friedmud
Copy link
Contributor Author

In 715c5e0:

fixup second order test with new error message refs #2358

@friedmud
Copy link
Contributor Author

In c689b96:

Fixup Actions that weren't registered properly that caused issues with finding the maximum number of qps closes #2378 refs #2358

@friedmud
Copy link
Contributor Author

In f0c0460:

make coupled() return a unique index for unsupplied optionally coupled variabes refs #2358

friedmud added a commit that referenced this issue Feb 14, 2014
friedmud added a commit that referenced this issue Feb 14, 2014
permcody added a commit that referenced this issue Feb 14, 2014
permcody added a commit that referenced this issue Feb 14, 2014
friedmud added a commit that referenced this issue Feb 14, 2014
…h finding the maximum number of qps closes #2378 refs #2358

r23951
friedmud added a commit that referenced this issue Feb 14, 2014
@friedmud friedmud reopened this Apr 16, 2014
friedmud added a commit to friedmud/moose that referenced this issue Apr 30, 2014
friedmud added a commit to friedmud/moose that referenced this issue Apr 30, 2014
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Apr 30, 2014
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

2 participants