Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a composition time stepper #23740

Closed
GiudGiud opened this issue Mar 15, 2023 · 2 comments · Fixed by #24046
Closed

Add a composition time stepper #23740

GiudGiud opened this issue Mar 15, 2023 · 2 comments · Fixed by #24046
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Mar 15, 2023

Reason

Sometimes we want to benefit from the behavior of multiple time steppers, but save for re-implementing what s missing (for example IterationAdaptiveDT did that), you cant mix & match

Tied to #8127 and #3858

Design

  • allow timestepper action to create multiple timesteppers (force the selection of one if multiple)
  • add a composition rule time stepper that can call the others
    max step, min step, average of steppers' step, times to hit absolutely (or with a tolerance?), periods of validity for each composed stepper etc

The periods of validity could be a parameter of each stepper instead

This would be a lot less intrusive than the Stepper system designed by @friedmud in #8127

Impact

Reaching full & final capability for time steppers?

@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. labels Mar 15, 2023
@MengnanLi91
Copy link
Contributor

@GiudGiud I can work on this

@friedmud
Copy link
Contributor

Yeah - I like this. Now that we've done this a few times with sub-Generators, etc... I think we know that this pattern works pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants