Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CircularCorrectionGenerator #23972

Closed
miaoyinb opened this issue Apr 4, 2023 · 0 comments · Fixed by #24006
Closed

Add CircularCorrectionGenerator #23972

miaoyinb opened this issue Apr 4, 2023 · 0 comments · Fixed by #24006
Labels
T: task An enhancement to the software.

Comments

@miaoyinb
Copy link
Contributor

miaoyinb commented Apr 4, 2023

Reason

As many mesh generators in Reactor Module have intrinsic "volume preserve" feature to correct polygonization effect during meshing. Circular boundaries in pre-existent file meshes as well as in meshes generated by MGs like ParsedCurveGenerator are not correct. A mesh generator that can perform circular correction for these meshes is needed.

Design

Take a series of sidesets and calculate the correction factor. Then the nodes on and near the circular boundaries should be moved to the corrected position.

Impact

Help achieve volume preserve, especially in reactor simulations.
@miaoyinb miaoyinb added the T: task An enhancement to the software. label Apr 4, 2023
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 7, 2023
@miaoyinb
Enable Circular Boundaries Correction
93a809a 
closes idaholab#23972
@miaoyinb miaoyinb mentioned this issue Apr 7, 2023
Merged
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 11, 2023
@miaoyinb
Enable Circular Boundaries Correction
4505950 
closes idaholab#23972
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 18, 2023
@miaoyinb
Enable Circular Boundaries Correction
dd04a97 
closes idaholab#23972
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 21, 2023
@miaoyinb
Enable Circular Boundaries Correction
16da66b 
closes idaholab#23972
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 23, 2023
@miaoyinb
Enable Circular Boundaries Correction
33b76d1 
closes idaholab#23972
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 26, 2023
@miaoyinb
Enable Circular Boundaries Correction
3e60058 
closes idaholab#23972
miaoyinb added a commit to miaoyinb/moose that referenced this issue Apr 28, 2023
@miaoyinb
Enable Circular Boundaries Correction
54a0f65 
closes idaholab#23972
chaibhave pushed a commit to chaibhave/moose that referenced this issue Jul 17, 2023
@miaoyinb @chaibhave
Enable Circular Boundaries Correction
73c09e0 
closes idaholab#23972
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 17, 2023
@GiudGiud
Better debug output when working with bad circular boundaries
508957a 
and trying to get their shape corrected
refs idaholab#23972
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 18, 2023
@GiudGiud
Better debug output when working with bad circular boundaries
23bd65d 
and trying to get their shape corrected
refs idaholab#23972
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @oanaoana
Better debug output when working with bad circular boundaries
cc8aa24 
and trying to get their shape corrected
refs idaholab#23972
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
@GiudGiud @oanaoana
Better debug output when working with bad circular boundaries
6e4410a 
and trying to get their shape corrected
refs idaholab#23972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Circular Boundaries Correction miaoyinb/moose
1 participant
@miaoyinb