Enable Circular Boundaries Correction

[miaoyinb]

closes #23972

Reason

Design

Impact

[moosebuild]

Job Documentation on 08a81a3 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage on 08a81a3 wanted to post the following:

Framework coverage

	7cf257	#24006 08a81a
	Total	Total	+/-	New
Rate	85.14%	85.17%	+0.03%	94.56%
Hits	86880	87106	+226	226
Misses	15160	15168	+8	13

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_conduction
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_properties
• stochastic_tools
• tensor_mechanics
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[GiudGiud]

@oanaoana for input on pinning meshes to higher order curves

[moosebuild]

Job Python spack on 1f19d28 : invalidated by @miaoyinb

[roystgnr]

I'd feel safer if someone else has time to look over this too, but the "segfault with DistributedMesh" issue was the only serious one I could find.

[moosebuild]

Job Framework increased sparsity on 16142af : invalidated by @miaoyinb

[GiudGiud]

I did some testing:

• if the boundaries are refined, either using uniform refinement or the XYDelaunay refinement option (looks like this)

then it doesnt fix the volume. Though it does trigger the circularness check if 'custom_circular_tolerance' is not raised

• if the boundary is a full circle, move_end_nodes_in_span_direction doesn't make sense so we need an error

• if the boundary does not exist, we get a not enough nodes message. It would be clearer to say:
  "boundary xx does not exist in the mesh"

• if the sideset contains the sets of sides duplicated (pointing both directions), which seems to happen with ParsedGenerateSideset, then the creation of the ordered node sets fails, hence the radius cant be corrected.

• if the CircularBoundaryCorrection is used twice on the same boundary, it makes it grow. This seems obvious, I was just
  thinking of ways a user could mess this up.

I think we could reasonably defend against the first 3 things. Maybe the 4th

[miaoyinb]

I think this circular correction should be done before refining.

(1)(2) fixed.
I am working on (3).
(4) would be complex...

[miaoyinb]

(3) done

[GiudGiud]

awesome! Thanks for meeting the additional requests