Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD version of CoupledVarNeumanBC #26413

Closed
lynnmunday opened this issue Dec 24, 2023 · 0 comments · Fixed by #26414
Closed

AD version of CoupledVarNeumanBC #26413

lynnmunday opened this issue Dec 24, 2023 · 0 comments · Fixed by #26414
Assignees
@lynnmunday
Labels
C: Framework T: task An enhancement to the software.

Comments

@lynnmunday
Copy link
Contributor

lynnmunday commented Dec 24, 2023 •
edited by lindsayad
Loading

Reason

Optimization problems that use the ForwardAdjoint executioner need a perfect jacobian for the adjoint problem which is really easy to do if I can use AD. For the problem I'm trying to solve, I need AD version of CoupledVarNeumanBC.

Design

Use is_ad templated class.

Impact
@lynnmunday lynnmunday added the T: task An enhancement to the software. label Dec 24, 2023
lynnmunday added a commit to lynnmunday/moose that referenced this issue Dec 24, 2023
@lynnmunday
create ad templated class of cupledVarNeumannBC closes idaholab#26413
31a2034
@lynnmunday lynnmunday mentioned this issue Dec 24, 2023
Merged
lynnmunday added a commit to lynnmunday/moose that referenced this issue Dec 27, 2023
@lynnmunday
address reviewer comments. closes idaholab#26413
17534d0
@lindsayad lindsayad changed the title AD version of CopuledVarNeumanBC AD version of CoupledVarNeumanBC Dec 28, 2023
lynnmunday added a commit to lynnmunday/moose that referenced this issue Dec 29, 2023
@lynnmunday
address reviewer comments. closes idaholab#26413
561fcf2
lynnmunday added a commit to lynnmunday/moose that referenced this issue Jan 1, 2024
@lynnmunday
create ad templated class of cupledVarNeumannBC closes idaholab#26413
214d018
lynnmunday added a commit to lynnmunday/moose that referenced this issue Jan 1, 2024
@lynnmunday
address reviewer comments. closes idaholab#26413
bf93c6b
lynnmunday added a commit to lynnmunday/moose that referenced this issue Jan 1, 2024
@lynnmunday
Using newer templated is_ad pattern. closes idaholab#26413
5c057f9
dschwen added a commit that referenced this issue Jan 2, 2024
@dschwen
Merge pull request #26414 from lynnmunday/adCoupledVarNeumann
c835ce5 
create ad templated class of coupledVarNeumannBC closes #26413
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Jan 5, 2024
@lynnmunday @maxnezdyur
create ad templated class of cupledVarNeumannBC closes idaholab#26413
129919f
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Jan 5, 2024
@lynnmunday @maxnezdyur
address reviewer comments. closes idaholab#26413
3176ecd
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Jan 5, 2024
@lynnmunday @maxnezdyur
Using newer templated is_ad pattern. closes idaholab#26413
dd296d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lynnmunday lynnmunday

Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create ad templated class of coupledVarNeumannBC closes #26413 lynnmunday/moose
2 participants
@lindsayad @lynnmunday