Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIDTransientControl object enhancement #26742

Closed
jthano opened this issue Feb 5, 2024 · 0 comments · Fixed by #26743
Closed

PIDTransientControl object enhancement #26742

jthano opened this issue Feb 5, 2024 · 0 comments · Fixed by #26743
Assignees
Labels
C: Framework T: task An enhancement to the software.

Comments

@jthano
Copy link
Contributor

jthano commented Feb 5, 2024

Reason

PIDTransientControl checks if the executioner is Transient and outputs a mooseError if it isn't. However, at least one moose based app has executioners that are "quasi" transients but inherit from Eigenvalue instead of Transient since inheriting from both is not possible. The PIDTransientControl can be used with these executioners if the check is changed to if (!_fe_problem.isTransient()). Furthermore, PIDTransientControl would be more useful with two parameters that allow a user to limit the output value between a minimum and maximum value.

Design

Update the check in the constructor to if (!_fe_problem.isTransient()) and add two new parameters.

Impact

PIDTransientControl will be more useful in Griffin and potentially other moose based apps.

@jthano jthano added the T: task An enhancement to the software. label Feb 5, 2024
jthano added a commit to jthano/moose that referenced this issue Feb 5, 2024
jthano added a commit to jthano/moose that referenced this issue Feb 5, 2024
jthano added a commit to jthano/moose that referenced this issue Feb 5, 2024
jthano added a commit to jthano/moose that referenced this issue Feb 6, 2024
jthano added a commit to jthano/moose that referenced this issue Feb 6, 2024
jthano added a commit to jthano/moose that referenced this issue Feb 6, 2024
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants