addressing comments idaholab#26742

jthano · Feb 6, 2024 · 8c2c91e · 8c2c91e
1 parent 936c27c
commit 8c2c91e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/framework/src/controls/PIDTransientControl.C b/framework/src/controls/PIDTransientControl.C
@@ -78,9 +78,10 @@ PIDTransientControl::PIDTransientControl(const InputParameters & parameters)
     _old_delta(0)
 {
   if (!_fe_problem.isTransient())
-    mooseWarning("PIDTransientControl is only meant to be used when the problem is transient, for "
-                 "example with a Transient Executioner. If using a Steady "
-                 "Executioner, make sure to specify a minimum number of Picard iterations.");
+    mooseError("PIDTransientControl is only meant to be used when the problem is transient, for "
+               "example with a Transient Executioner. Support for Steady "
+               "Executioner can be added in the future, however certain parameters are currently "
+               "not well defined for use with Picard iterations.");
 
   if (isParamValid("parameter") && isParamValid("parameter_pp"))
     paramError("parameter_pp",

diff --git a/test/tests/controls/pid_control/tests b/test/tests/controls/pid_control/tests
@@ -8,7 +8,6 @@
       input = 'pid_control.i'
       csvdiff = 'out.csv'
       recover = false
-      # Not ouputting left_boundary_average to avoid regold
       cli_args = 'Postprocessors/left_boundary_average/outputs=none'
       detail = 'using the principle of Proportional Integral Derivative control,'
     []
@@ -17,7 +16,6 @@
       input = 'pid_control.i'
       csvdiff = 'min_max_limits.csv'
       recover = false
-      # Not ouputting left_boundary_average to avoid regold
       cli_args = 'Outputs/file_base=min_max_limits Controls/integral_value/maximum_output_value=4.0 Controls/integral_value/minimum_output_value=2.0 Executioner/nl_abs_tol=1e-12 Executioner/end_time=10'
       detail = 'allowing the Proportional Integral Derivative control to have limits for its maximum and minimum output,'
     []    
@@ -34,7 +32,6 @@
       input = 'pid_control.i'
       csvdiff = 'windup_out.csv'
       recover = false
-      # Not ouputting left_boundary_average to avoid regold
       cli_args = 'Outputs/file_base=windup_out Controls/integral_value/reset_integral_windup=true Postprocessors/left_boundary_average/outputs=none'
       detail = 'with integral windup control, resetting the integral term if the error crosses zero,'
     []