Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FunctionIC::gradient(const Point &) #3312

Closed
dschwen opened this issue Jun 6, 2014 · 2 comments
Closed

Implement FunctionIC::gradient(const Point &) #3312

dschwen opened this issue Jun 6, 2014 · 2 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Jun 6, 2014

FunctionIC::gradient(const Point &) is not implemented, even though the Function class has the method. I don't see a reason why we shouldn't pass the gradient from function through.

The next step is using the FParser auto differentiation to compute the gradient in MooseParsedFunction::gradient(const Point &). That way we would correctly initialize variables using higher order base functions (e.g. THIRD order HERMITE).
dschwen added a commit to dschwen/moose that referenced this issue Jun 6, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
8124fb4
@dschwen dschwen mentioned this issue Jun 6, 2014
Merged
dschwen added a commit to dschwen/moose that referenced this issue Jun 6, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
fe61eab
@dschwen
Copy link
Member Author

dschwen commented Jun 6, 2014

MooseParsedGradFunction is a MooseParsedFunction with explicitly specified gradient components (as Function Parser expressions). This could/should probably be retired in favor of auto differentiation, unless there is a good reason to allow the user to specify a (potentially wrong) hand-made derivative. This will still be needed, as we cannot autodiff the additional variables which may depend on xyzt.

dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
99ebade
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
37a9ec4
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
5b4cee7
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
protect under development libMesh functionality (idaholab#3312)
419ee77
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
e9cd284
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
94308d6
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
1728baa
dschwen added a commit to dschwen/moose that referenced this issue Jun 10, 2014
@dschwen
protect under development libMesh functionality (idaholab#3312)
2c66ce6
dschwen added a commit to dschwen/moose that referenced this issue Jun 12, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
512ca2f
dschwen added a commit to dschwen/moose that referenced this issue Jun 12, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
7bcc307
dschwen added a commit to dschwen/moose that referenced this issue Jun 12, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
b2be9d8
dschwen added a commit to dschwen/moose that referenced this issue Jun 12, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
acfc7f8
dschwen added a commit to dschwen/moose that referenced this issue Jun 12, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
f398379
dschwen added a commit to dschwen/moose that referenced this issue Jun 12, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
31e0210
dschwen added a commit to dschwen/moose that referenced this issue Jun 23, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
545f068
dschwen added a commit to dschwen/moose that referenced this issue Jun 23, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
2ac3486
dschwen added a commit to dschwen/moose that referenced this issue Jun 23, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
6d7d73b
dschwen added a commit to dschwen/moose that referenced this issue Jun 23, 2014
@dschwen
start working on FunctionIC gradient test (idaholab#3312)
ae595eb
dschwen added a commit to dschwen/moose that referenced this issue Jun 23, 2014
@dschwen
Pass gradients though in FunctionIC. Add tests. (idaholab#3312)
918adea
dschwen added a commit to dschwen/moose that referenced this issue Jun 30, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
98b487b
dschwen added a commit to dschwen/moose that referenced this issue Jun 30, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
818385e
dschwen added a commit to dschwen/moose that referenced this issue Jun 30, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
f1e3288
dschwen added a commit to dschwen/moose that referenced this issue Jun 30, 2014
@dschwen
start working on FunctionIC gradient test (idaholab#3312)
25f994c
dschwen added a commit to dschwen/moose that referenced this issue Jun 30, 2014
@dschwen
Pass gradients though in FunctionIC. Add tests. (idaholab#3312)
c8124c2
dschwen added a commit to dschwen/moose that referenced this issue Jun 30, 2014
@dschwen
regold and enable spline function IC test (idaholab#3312)
81d48c3
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
Pass gradient through from the function. (idaholab#3312)
8a967aa
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
Implement gradient for SplineFunction. (idaholab#3312)
f027adf
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
add gradient and dot to NooseParsedFunctionWrapper (idaholab#3312)
ce71b2a
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
start working on FunctionIC gradient test (idaholab#3312)
acb1567
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
Pass gradients though in FunctionIC. Add tests. (idaholab#3312)
3dcfdc2
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
regold and enable spline function IC test (idaholab#3312)
56b1239
dschwen added a commit to dschwen/moose that referenced this issue Jul 1, 2014
@dschwen
test only for IC, no solve (idaholab#3312)
e7fbf78
@dschwen
Copy link
Member Author

dschwen commented Jul 3, 2014

With the merged PR this should be done now.

@dschwen dschwen closed this as completed Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dschwen @permcody