Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move (Derivative)ParsedMaterial into framework #5039

Closed
dschwen opened this issue May 6, 2015 · 5 comments
Closed

Move (Derivative)ParsedMaterial into framework #5039

dschwen opened this issue May 6, 2015 · 5 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented May 6, 2015

There is nothing that makes these materials specific to the phase_field module. ParsedMaterial can be used in many applications to generate material properties that are functions of non-linear variables. The autodiffed DeriviativeParsedMaterial does not necessarily have to represent a free energy either. @tonkmr

The Doxygen pages for the classes in question are

Note that there are a few parent classes that would have to be moved as well (DerivativeMaterialInterface and DerivativeMaterialPropertyNameInterface are already located in framework).

@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels May 7, 2015
@dschwen
Copy link
Member Author

dschwen commented Oct 30, 2015

Requesting feedback from @permcody and @friedmud. At least that will give me a definitive NO! and we can close this issue ;-).

@friedmud
Copy link
Contributor

Sigh. It's hard to argue against the utility. But the "abuse" is going to be rampant. People will shoehorn entire applications into ParsedMaterials just to avoid using our "lovingly crafted" C++ ;-)

I honestly don't know what to do here. It's one of those situations where this is obviously cool... and possibly able to destroy everything.

I'll wait to hear from @permcody

@permcody
Copy link
Member

permcody commented Nov 2, 2015

I'm willing to give this a shot. We'll avoid using it in our examples and tutorials for the time being and keep people away from the dark side but it is very useful. We can always put out guidelines for people on what tools they should use for what purposes.

@lindsayad
Copy link
Member

Just today I was wondering why (Derivative)ParsedMaterial is in a module instead of the framework. I'm glad I checked here. I have a whole set of fuel salts, each of whose material properties (conductivity, density, heat capacity, etc.) are slightly different functions of temperature. Instead of hard-coding twenty different materials, ParsedMaterial seems like the way to go. So now I'm including the phase_field module in my application just for that capability even though I couldn't write down governing equations for a phase field problem if you held a gun to my head.

@dschwen
Copy link
Member Author

dschwen commented Mar 31, 2017

Yeah, let me prepare a PR and we can discuss this further.

dschwen added a commit to dschwen/moose that referenced this issue Mar 31, 2017
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 30, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 31, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 31, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

4 participants