Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDP and PBP tests are not converging in a single iteration #5153

Closed
permcody opened this issue Jun 1, 2015 · 2 comments
Closed

FDP and PBP tests are not converging in a single iteration #5153

permcody opened this issue Jun 1, 2015 · 2 comments
Labels
C: Framework T: defect An anomaly, which is anything that deviates from expectations.

Comments

@permcody
Copy link
Member

permcody commented Jun 1, 2015

The FDB and PBP Precondition tests do not converge in a single iteration. Our current tests erroneously miss the fact that the final solution is not fully converged when they exit due to a missing error message.
@permcody permcody added C: Framework P: critical T: defect An anomaly, which is anything that deviates from expectations. labels Jun 1, 2015
permcody added a commit to permcody/moose that referenced this issue Jun 1, 2015
@permcody
Add message to Steady executioner
36c4aff 
closes idaholab#5144, refs idaholab#5153
@permcody permcody mentioned this issue Jun 1, 2015
Merged
permcody added a commit to permcody/moose that referenced this issue Jun 2, 2015
@permcody
Add message to Steady executioner
ba72bdc 
closes idaholab#5144, refs idaholab#5153
j2bradley pushed a commit to j2bradley/moose that referenced this issue Jun 17, 2015
@permcody @j2bradley
Add message to Steady executioner
5fb382b 
closes idaholab#5144, refs idaholab#5153
jbair34 pushed a commit to jbair34/moose that referenced this issue Mar 1, 2016
@permcody @jbair34
Add message to Steady executioner
684b93b 
closes idaholab#5144, refs idaholab#5153
@fdkong
Copy link
Contributor

fdkong commented Oct 3, 2017

@permcody, why FDP and PBP are supposed to converge within one iteration? I do not understand this. Could you explain more?

@permcody
Copy link
Member Author

permcody commented Oct 3, 2017

I honestly don't remember why I said this. I think what I was thinking was that it should converge in a single nonlinear iteration due to the fact that the problem was very simple and the preconditioner was very good. However, it just wasn't and worse, it was actually failing prior to the fix I merged in here from another developer. I'm OK with removing or updating this ticket as appropriate. What does the convergence look like now?

fdkong added a commit to fdkong/moose that referenced this issue Oct 3, 2017
@fdkong
FDP: enabled the test deleted by idaholab#5153
6015625 
Refs idaholab#5153
fdkong added a commit to fdkong/moose that referenced this issue Oct 4, 2017
@fdkong
FDP: enabled the test deleted by idaholab#5153
479cfc9 
Closes  idaholab#5153
jarons pushed a commit to jarons/moose that referenced this issue Oct 5, 2017
@fdkong @jarons
FDP: enabled the test deleted by idaholab#5153
c632697 
Closes  idaholab#5153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @fdkong