Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial_from_file_timestep should be able to grab "end" #5748

Closed
mangerij opened this issue Sep 28, 2015 · 2 comments
Closed

initial_from_file_timestep should be able to grab "end" #5748

mangerij opened this issue Sep 28, 2015 · 2 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@mangerij
Copy link
Contributor

If end(ie the last timestep) is tried in the restart system, the following error is thrown.

ERROR: Input value for variable GlobalParams/initial_from_file_timestep is of the wrong type. value = end expected type = i

Would this be easy to change?

@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Sep 29, 2015
@permcody
Copy link
Member

Yes, We've already solved this problem with the block and boundary parameters in MOOSE. We just changed the type to string and then attempt to convert them to integers. If they successfully convert without leaving left over characters, we know they are actually integers and we can treat them as such. If they don't convert, then we can attempt to treat them as a string and do something different. This is a good idea and I think it's been proposed before, but I'll leave this new version open as a reminder.

@friedmud
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

3 participants