Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeNodalKernel not tested #5949

Closed
permcody opened this issue Nov 10, 2015 · 1 comment
Closed

TimeNodalKernel not tested #5949

permcody opened this issue Nov 10, 2015 · 1 comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@permcody
Copy link
Member

I see a test for this but it doesn't appear to get hit:

http://mooseframework.org/docs/coverage/moose/coverage/src/nodalkernels/TimeNodalKernel.C.gcov.html

ping @friedmud
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Nov 10, 2015
@friedmud
Copy link
Contributor

aha!!

I think you just found why time integration is screwed up with NodalKernels (ie, in #5883 )!

TimeDerivativeNodalKernel is inheriting from the wrong base class! It's inheriting from NodalKernel when it should be inheriting from TimeNodalKernel!

That means that it's residual contributions are going into the wrong residual vector... which is screwing up our high order time integration.

I'll check this out later tonight and report back with the results.

Thanks for finding this!

@friedmud friedmud mentioned this issue Nov 11, 2015
Closed
friedmud added a commit to friedmud/moose that referenced this issue Nov 11, 2015
@friedmud
Make TimeDerivativeNodalKernel inherit from TimeNodalKernel closes id…
33782ff 
…aholab#5883 closes idaholab#5949
@friedmud friedmud mentioned this issue Nov 11, 2015
Merged
friedmud added a commit to friedmud/moose that referenced this issue Dec 18, 2015
@friedmud
Make TimeDerivativeNodalKernel inherit from TimeNodalKernel closes id…
867cca4 
…aholab#5883 closes idaholab#5949
friedmud added a commit that referenced this issue Dec 18, 2015
@friedmud
Make TimeDerivativeNodalKernel inherit from TimeNodalKernel closes #5883
afcf3b7 
 closes #5949
friedmud added a commit to friedmud/moose that referenced this issue Dec 19, 2015
@friedmud
Make TimeDerivativeNodalKernel inherit from TimeNodalKernel closes id…
7f75e5b 
…aholab#5883 closes idaholab#5949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@friedmud @permcody