Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to SimplePredictor to skip specified time steps #6506

Closed
bwspenc opened this issue Mar 4, 2016 · 1 comment
Closed

Add option to SimplePredictor to skip specified time steps #6506

bwspenc opened this issue Mar 4, 2016 · 1 comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@bwspenc
Copy link
Contributor

bwspenc commented Mar 4, 2016

Description of the enhancement or error report

Add option to SimplePredictor to skip application of the predictor at specified steps.

Rationale for the enhancement or information for reproducing the error

SimplePredictor is very helpful in many cases with monotonic loading, but if the loading is not monotonic, it can make convergence worse. This option would allow the user to skip the predictor on steps where it is known that the loading will not be monotonic.

Identified impact

Changes to SimplePredictor.C
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add option to skip specified times in predictors ref idaholab#6506
e0de640
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add test for skip_times option in Predictor closes idaholab#6506
cae594b
@bwspenc
Copy link
Contributor Author

bwspenc commented Mar 4, 2016

Actually, after coding this up, I think this makes more sense to do in the base class. That's how I've implemented it.

bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add option to skip specified times in predictors ref idaholab#6506
70640a7
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add test for skip_times option in Predictor closes idaholab#6506
7db291d
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add test for skip_times option in Predictor closes idaholab#6506
8dc8c3e
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add option to skip specified times in predictors ref idaholab#6506
3e5f806
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 4, 2016
@bwspenc
Add test for skip_times option in Predictor closes idaholab#6506
052b00b
@bwspenc bwspenc mentioned this issue Mar 4, 2016
Merged
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 7, 2016
@bwspenc
Add tests for skip_times option in Predictor closes idaholab#6506
c048dd1 
Modify existing test in solid_mechanics and add version of the
test to skip the predictor on a step.  Add similar framework
tests.
Also add and test options to specify the residual type in the
Residual postprocessor to allow us to more reliably test the predictor.
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 7, 2016
@bwspenc
Add option to skip specified times in predictors ref idaholab#6506
4f33133
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 7, 2016
@bwspenc
Add tests for skip_times option in Predictor closes idaholab#6506
704e39f 
Modify existing test in solid_mechanics and add version of the
test to skip the predictor on a step.  Add similar framework
tests.
Also add and test options to specify the residual type in the
Residual postprocessor to allow us to more reliably test the predictor.
bwspenc added a commit to bwspenc/moose that referenced this issue Mar 7, 2016
@bwspenc
Add tests for skip_times option in Predictor closes idaholab#6506
d7b797c 
Modify existing test in solid_mechanics and add version of the
test to skip the predictor on a step.  Add similar framework
tests.
Also add and test options to specify the residual type in the
Residual postprocessor to allow us to more reliably test the predictor.
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Mar 8, 2016
@bwspenc bwspenc mentioned this issue Mar 11, 2016
Closed
SudiptaBiswas pushed a commit to SudiptaBiswas/moose that referenced this issue Mar 29, 2016
@bwspenc
Add option to skip specified times in predictors ref idaholab#6506
f2cf40d
SudiptaBiswas pushed a commit to SudiptaBiswas/moose that referenced this issue Mar 29, 2016
@bwspenc
Add tests for skip_times option in Predictor closes idaholab#6506
f0ab802 
Modify existing test in solid_mechanics and add version of the
test to skip the predictor on a step.  Add similar framework
tests.
Also add and test options to specify the residual type in the
Residual postprocessor to allow us to more reliably test the predictor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @bwspenc