Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterned mesh #6950

Merged
merged 3 commits into from May 11, 2016
Merged

Patterned mesh #6950

merged 3 commits into from May 11, 2016

Conversation

jwpeterson
Copy link
Member

Replaces #6831.

Adds Doxygen comments, class description, and whitespace fixes as requested by reviewers.

friedmud and others added 2 commits May 10, 2016 13:15
@friedmud @jwpeterson
Add PatternedMesh closes idaholab#6830
2e09798
@jwpeterson
Add documentation as requested by reviewers.
f8a69ae 
Also clean up trailing whitespace; add newline at end of files.
@jwpeterson jwpeterson mentioned this pull request May 10, 2016
Closed
@jwpeterson
Copy link
Member Author

Looks like we ran out of space on the build box...

/tmp/ccL54vMf.s: Assembler messages:
/tmp/ccL54vMf.s: Fatal error: can't write richards/src/kernels/.libs/RichardsFlux.x86_64-unknown-linux-gnu.dbg.o: No space left on device
/tmp/ccL54vMf.s: Fatal error: can't close richards/src/kernels/.libs/RichardsFlux.x86_64-unknown-linux-gnu.dbg.o: No space left on device

permcody
permcody reviewed May 10, 2016
View reviewed changes
framework/src/mesh/PatternedMesh.C

params.addParam<Real>("x_width", 0, "The tile width in the x direction");
params.addParam<Real>("y_width", 0, "The tile width in the y direction");
params.addParam<Real>("z_width", 0, "The tile width in the z direction");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should use addCheckedRangeParam here to make sure these are positive reals.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can do this real quick.

@friedmud
Copy link
Contributor

Thanks @jwpeterson ! I was going to get tooth of these this week... but it lookalike you guys got tired of waiting 😄

@permcody
Copy link
Member

👍

@permcody permcody merged commit 0eede80 into idaholab:devel May 11, 2016
@jwpeterson jwpeterson deleted the patterned_mesh branch May 12, 2016 13:58
@permcody
Copy link
Member

Ah @friedmud - it's good to know nothing has changed. One commit to the framework and we aren't valgrind clean....
https://www.moosebuild.org/job/22221/

@jwpeterson
Copy link
Member Author

This is the bug, loop needs to go to _row_meshes.size()

  for (unsigned int i = 1; i < _meshes.size(); i++)
    delete _row_meshes[i];

@jwpeterson
Copy link
Member Author

I will put in a PR to fix that

jwpeterson added a commit to jwpeterson/moose that referenced this pull request May 12, 2016
@jwpeterson
Make sure all _row_meshes are deleted.
d92cbe1 
Refs idaholab#6950.
@jwpeterson jwpeterson mentioned this pull request May 12, 2016
Merged
@permcody
Copy link
Member

Let's shrink and regold this monster too. This test is too big and timing out in parallel debug mode.

@jwpeterson
Copy link
Member Author

Let's shrink and regold this monster too.

OK, I'll do that on #6964 too.

jwpeterson added a commit to jwpeterson/moose that referenced this pull request May 12, 2016
@jwpeterson
Regold test with a smaller pattern to hopefully prevent timeouts.
4366815 
Refs idaholab#6950.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwpeterson @friedmud @permcody