New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterned mesh #6950
Patterned mesh #6950
Conversation
Also clean up trailing whitespace; add newline at end of files.
Looks like we ran out of space on the build box...
|
|
||
params.addParam<Real>("x_width", 0, "The tile width in the x direction"); | ||
params.addParam<Real>("y_width", 0, "The tile width in the y direction"); | ||
params.addParam<Real>("z_width", 0, "The tile width in the z direction"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should use addCheckedRangeParam here to make sure these are positive reals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I can do this real quick.
Thanks @jwpeterson ! I was going to get tooth of these this week... but it lookalike you guys got tired of waiting 😄 |
👍 |
Ah @friedmud - it's good to know nothing has changed. One commit to the framework and we aren't valgrind clean.... |
This is the bug, loop needs to go to
|
I will put in a PR to fix that |
Let's shrink and regold this monster too. This test is too big and timing out in parallel debug mode. |
OK, I'll do that on #6964 too. |
Replaces #6831.
Adds Doxygen comments, class description, and whitespace fixes as requested by reviewers.