Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior of IterationAdaptiveTimeStepper as sub app #7842

Closed
snschune opened this issue Oct 10, 2016 · 1 comment
Closed

Behavior of IterationAdaptiveTimeStepper as sub app #7842

snschune opened this issue Oct 10, 2016 · 1 comment
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@snschune
Copy link
Contributor

Description of the enhancement or error report

The behavior occurs when IterationAdaptiveDT is used in the sub app, without sub-cycling and
the master does not constrain the time step. In that case if the time step should be increased
due to fast convergence, it does not happen until one time step later.

Rationale for the enhancement or information for reproducing the error

An example will be provided.

Identified impact

(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)
snschune pushed a commit to snschune/moose that referenced this issue Oct 10, 2016
An example for iteration adaptive timestepper in multiapp (idaholab#7842
36ffd72 
)
@permcody permcody added C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations. labels Oct 10, 2016
@rwcarlsen
Copy link
Contributor

probably due to this line: https://github.com/idaholab/moose/blob/devel/framework/src/timesteppers/IterationAdaptiveDT.C#L177

And likely addressed by time stepper changes in the near future.

@rwcarlsen rwcarlsen mentioned this issue Dec 5, 2016
Open
@snschune snschune mentioned this issue Nov 28, 2017
Closed
@lindsayad lindsayad mentioned this issue Nov 28, 2017
Merged
lindsayad pushed a commit to lindsayad/moose that referenced this issue Nov 30, 2017
@lindsayad
An example for iteration adaptive timestepper in multiapp (idaholab#7842
0131544 
)
lindsayad pushed a commit to lindsayad/moose that referenced this issue Nov 30, 2017
@lindsayad
An example for iteration adaptive timestepper in multiapp (idaholab#7842
14a6e8e 
)
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 30, 2017
@lindsayad
Actually will use split methods. Add test. Closes idaholab#7842
7390e3c
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 30, 2017
@lindsayad
Write more documentation. (Closes idaholab#7842)
b1e8875
@lindsayad lindsayad mentioned this issue Nov 30, 2017
Merged
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 30, 2017
@lindsayad
Change LevelSet MultiApp interface to match new MultiApp (Closes idah…
cfdd5ec 
…olab#7842)
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Add back advanceStep as deprecated method. Adjust doco (Closes idahol…
b7ce8ec 
…ab#7842)
lindsayad pushed a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
An example for iteration adaptive timestepper in multiapp (idaholab#7842
d13d095 
)
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Actually will use split methods. Add test. Closes idaholab#7842
5da916e
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Write more documentation. (Closes idaholab#7842)
c8d8f08
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Change LevelSet MultiApp interface to match new MultiApp (Closes idah…
1a14f4c 
…olab#7842)
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Add back advanceStep as deprecated method. Adjust doco (Closes idahol…
71f475e 
…ab#7842)
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Make new API non-pure virtual for now (Closes idaholab#7842)
93be2d9
lindsayad added a commit to lindsayad/moose that referenced this issue Dec 5, 2017
@lindsayad
Deprecate old FEProblemBase method (idaholab#7842)
9d30a91
lindsayad pushed a commit to lindsayad/moose that referenced this issue Feb 6, 2018
@lindsayad
An example for iteration adaptive timestepper in multiapp (idaholab#7842
2943e9d 
)
lindsayad added a commit to lindsayad/moose that referenced this issue Feb 6, 2018
@lindsayad
Use adapted time step from sub-app for loose coupling
bb5589c 
Fixes issue that when the master app does not restrict the time step and the sub-app adaptive
time stepper signals an increase in time step, then the change is not reflected until the
following time step.

Details:
- Split FEProblemBase::advanceMultiApps into incrementMultiAppTStep and finishMultiAppStep
- Similary split MultiApp::advanceStep into incrementTStep and finishStep
- Always call incrementMultiAppTStep in Transient::incrementStepOrReject

Closes idaholab#7842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwcarlsen @permcody @snschune