Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MooseRandom restartable #8225

Closed
jessecarterMOOSE opened this issue Dec 15, 2016 · 1 comment
Closed

Make MooseRandom restartable #8225

jessecarterMOOSE opened this issue Dec 15, 2016 · 1 comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@jessecarterMOOSE
Copy link
Contributor

jessecarterMOOSE commented Dec 15, 2016

Description of the enhancement or error report

The state of the MooseRandom system cannot currently be carried over from run to run. Restarted/recovered simulations will start over at the beginning of the random number sequence. There is no system for reading/writing the information about the mt_state type to file. Doing this should allow the system to be restartable.

Rationale for the enhancement or information for reproducing the error

Better restart/recover behavior.

Identified impact

(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)
None, additional capacity.

See discussion:
https://groups.google.com/forum/?hl=en#!topic/moose-users/pJyJUHc5eac

@jessecarterMOOSE
Copy link
Contributor Author

jessecarterMOOSE commented Dec 15, 2016

FWIW, I think the pieces to put together are these:

Moose variable holding the states for all generators is a map that holds a pair of states:
https://github.com/idaholab/moose/blob/devel/framework/include/utils/MooseRandom.h#L177

mt_state type is defined here:
https://github.com/idaholab/moose/blob/devel/framework/contrib/mtwist/include/mtwist.h#L175-L182

jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 19, 2016
jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 19, 2016
jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 20, 2016
jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 29, 2016
jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 29, 2016
jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 29, 2016
jessecarterMOOSE added a commit to jessecarterMOOSE/moose that referenced this issue Dec 29, 2016
@permcody permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

2 participants