Create structure for MaterialProperty dependencies #8444

lindsayad · 2017-02-01T20:15:03Z

Description of the enhancement or error report

Create structure for resolving MaterialProperty dependencies similar to what is done for coupleable MooseVariable dependencies. Thinking that MaterialPropertyInterface would take on some methods like getMatPropDependencies and addMatPropDependency and a set member like _material_property_dependencies.

getMatPropDependencies would then be called by an updateMatPropDependency method in the MaterialWarehouse which would in turn could be called by computing objects like ComputeResidualThread.

Rationale for the enhancement or information for reproducing the error

By smartly addressing material dependencies hopefully we can cut down on unnecessary material property calculations and speed up applications. Other Tiger Team participants can expound on this if I haven't quite gotten the grasp of the full scope (@permcody @jwpeterson @friedmud @YaqiWang @snschune).

Identified impact

Speed up applications

The text was updated successfully, but these errors were encountered:

… representing mat prop ids (idaholab#8444).

…8444).

…fect (idaholab#8444).

…#8444) - Also make material computing threads (e.g. ComputeResidualThread call the updateMatPropDependency methods) - Make sure that we don't mark as having material property dependencies simply because we call setActiveMaterialProperties in FEProblemBase/Subproblem

…holab#8444) - Test 1: don't call computeQpProperties for one material that doesn't supply any properties - Passes - Test 2: one material supplies properties. The other does not. Ideally only the one supplying properties should get called - Fails - Test 3: ensure that materials get computed for residual and jacobian threads because kernel needs property but that material does not get computed for elem_aux_var that does not need any properties

… representing mat prop ids (idaholab#8444).

…8444).

…fect (idaholab#8444).

…#8444) - Also make material computing threads (e.g. ComputeResidualThread call the updateMatPropDependency methods) - Make sure that we don't mark as having material property dependencies simply because we call setActiveMaterialProperties in FEProblemBase/Subproblem

…holab#8444) - Test 1: don't call computeQpProperties for one material that doesn't supply any properties - Passes - Test 2: one material supplies properties. The other does not. Ideally only the one supplying properties should get called - Fails - Test 3: ensure that materials get computed for residual and jacobian threads because kernel needs property but that material does not get computed for elem_aux_var that does not need any properties

…b#8444).

permcody · 2017-02-02T22:58:13Z

@lindsayad - we may be able to close #3502 here as well.

…8444)

…b#8444).

…8444)

- remove _has_active_material_property_ids from SubProblem.h - remove addMatPropDependency from MaterialPropertyInterface.h - remove this-> calls because it's implied you dope - swap checks in FEProblemBase

… representing mat prop ids (idaholab#8444).

…8444).

…fect (idaholab#8444).

…#8444) - Also make material computing threads (e.g. ComputeResidualThread call the updateMatPropDependency methods) - Make sure that we don't mark as having material property dependencies simply because we call setActiveMaterialProperties in FEProblemBase/Subproblem - Move from MooseSharedPointer to std::shared_ptr - Closed space between right angle brackets

…holab#8444) - Test 1: don't call computeQpProperties for one material that doesn't supply any properties - Passes - Test 2: one material supplies properties. The other does not. Ideally only the one supplying properties should get called - Fails - Test 3: ensure that materials get computed for residual and jacobian threads because kernel needs property but that material does not get computed for elem_aux_var that does not need any properties

…b#8444).

…8444)

- remove _has_active_material_property_ids from SubProblem.h - remove addMatPropDependency from MaterialPropertyInterface.h - remove this-> calls because it's implied you dope - swap checks in FEProblemBase

permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Feb 1, 2017

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 1, 2017

Initial work on mat prop dependencies (idaholab#8444).

adf213f

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 1, 2017

Change set from containing MaterialProperty pointers to unsigned ints…

8254d70

… representing mat prop ids (idaholab#8444).

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 1, 2017

Update material portions (idaholab#8444).

55c9b27

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 1, 2017

Add new checks and methods in FEProblemBase and SubProblem (idaholab#…

26473b6

…8444).

permcody added this to the Texas A&M Tiger Team milestone Feb 2, 2017

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Add test showing that new check FEProblemBase::reinitMaterials has ef…

d7dbfe5

…fect (idaholab#8444).

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Add IncrementMaterial test (idaholab#8444).

15a9a3f

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Initial work on mat prop dependencies (idaholab#8444).

a551175

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Change set from containing MaterialProperty pointers to unsigned ints…

047cd7f

… representing mat prop ids (idaholab#8444).

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Update material portions (idaholab#8444).

82f1b67

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Add new checks and methods in FEProblemBase and SubProblem (idaholab#…

3303415

…8444).

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Add test showing that new check FEProblemBase::reinitMaterials has ef…

4d118e2

…fect (idaholab#8444).

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Add IncrementMaterial test (idaholab#8444).

a3e67eb

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Add dependencies for other getProperty calls (idaholab#8444).

e6958fb

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Fix compute thread for ElemAuxBcs (idaholab#8444).

20c6fc4

permcody assigned lindsayad Feb 2, 2017

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Fix dirac kernels thread and LineMaterialSamplerBase thread. (idahola…

7eebb31

…b#8444).

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 2, 2017

Reenable resetQpProperties warning. (idaholab#8444).

da44a36

lindsayad mentioned this issue Feb 2, 2017

Only call material computeProperties when computing thread actually needs them #8467

Merged

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 3, 2017

Reenable resetQpProperties warning. (idaholab#8444).

6608f89

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 3, 2017

Reenable resetQpProperties warning. (idaholab#8444).

48f37c5

lindsayad added a commit to lindsayad/moose that referenced this issue Feb 3, 2017

Fix up ComputeElemAuxBcsThread and regold random_material. (idaholab#…

1a46d43

…8444)

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Add IncrementMaterial test (idaholab#8444).

5cfcec3

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Add dependencies for other getProperty calls (idaholab#8444).

54d6bed

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Fix compute thread for ElemAuxBcs (idaholab#8444).

369a344

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Fix dirac kernels thread and LineMaterialSamplerBase thread. (idahola…

db2996f

…b#8444).

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Reenable resetQpProperties warning. (idaholab#8444).

20457d0

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Fix up ComputeElemAuxBcsThread and regold random_material. (idaholab#…

e8962a6

…8444)

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

No threading allowed for increment test (idaholab#8444).

817c59f

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Add method documentation (idaholab#8444)

b5fea5f

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Convert to range based for loops (idaholab#8444)

aa12a2b

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Feb 28, 2017

Try removing hasActiveBlocks check (idaholab#8444)

396b646

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Initial work on mat prop dependencies (idaholab#8444).

f17e262

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Change set from containing MaterialProperty pointers to unsigned ints…

01aaffb

… representing mat prop ids (idaholab#8444).

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Update material portions (idaholab#8444).

b3a08cc

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Add new checks and methods in FEProblemBase and SubProblem (idaholab#…

08c2779

…8444).

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Add test showing that new check FEProblemBase::reinitMaterials has ef…

3dc5d35

…fect (idaholab#8444).

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Add IncrementMaterial test (idaholab#8444).

cb35fc1

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Add dependencies for other getProperty calls (idaholab#8444).

e1e42a7

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Fix compute thread for ElemAuxBcs (idaholab#8444).

0770b8f

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Fix dirac kernels thread and LineMaterialSamplerBase thread. (idahola…

a7464be

…b#8444).

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Reenable resetQpProperties warning. (idaholab#8444).

a17eca9

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Fix up ComputeElemAuxBcsThread and regold random_material. (idaholab#…

405e9be

…8444)

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

No threading allowed for increment test (idaholab#8444).

d26ada1

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Add method documentation (idaholab#8444)

1729413

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Convert to range based for loops (idaholab#8444)

ff95574

rwcarlsen pushed a commit to lindsayad/moose that referenced this issue Mar 13, 2017

Try removing hasActiveBlocks check (idaholab#8444)

d162117

aeslaughter closed this as completed in #8467 Mar 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create structure for MaterialProperty dependencies #8444

Create structure for MaterialProperty dependencies #8444

lindsayad commented Feb 1, 2017

permcody commented Feb 2, 2017

Create structure for MaterialProperty dependencies #8444

Create structure for MaterialProperty dependencies #8444

Comments

lindsayad commented Feb 1, 2017

Description of the enhancement or error report

Rationale for the enhancement or information for reproducing the error

Identified impact

permcody commented Feb 2, 2017