Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalParams should not be applied to suppressed parameters #8761

Closed
dschwen opened this issue Mar 20, 2017 · 5 comments · Fixed by #22592
Closed

GlobalParams should not be applied to suppressed parameters #8761

dschwen opened this issue Mar 20, 2017 · 5 comments · Fixed by #22592
Assignees
@permcody @socratesgorilla
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Mar 20, 2017

Description of the enhancement or error report

As discussed in #8760 parameters form the [GlobalParams] block should not be applied to parameters suppressed with suppressParameter.

Rationale for the enhancement or information for reproducing the error

suppressParameter should behave as if the parameter was never added in the first place. This is currently not the case. If a suppressed parameter is specified in GlobalParams and error is thrown.

Identified impact

Consistent API. This will allow us to suppress use_displaced_mesh in certain materials without having to forego the use of GlobalParams.
@permcody permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Mar 20, 2017
@permcody
Copy link
Member

permcody commented Sep 6, 2017

I know you guys are using this now. Is this still an issue and you are just working around it?

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 2, 2022

Yes this is still an issue.
@socratesgorilla would you want to tackle that? It s pretty annoying to a lot of people

@socratesgorilla
Copy link
Contributor

Sounds like a fitting task, go and ahead assign me

@YaqiWang
Copy link
Contributor

YaqiWang commented Nov 2, 2022

Maybe one stone kills two birds: #22480?

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 2, 2022

I like divide and conquer better

@socratesgorilla socratesgorilla mentioned this issue Nov 3, 2022
Merged
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Nov 3, 2022
Removed GlobalParams applying to suppressed parameters idaholab#8761
10662d5
socratesgorilla pushed a commit to socratesgorilla/moose that referenced this issue Nov 3, 2022
Removed GlobalParams applying to suppressed parameters idaholab#8761
0d9ff0a
GiudGiud pushed a commit to socratesgorilla/moose that referenced this issue Apr 11, 2023
@GiudGiud
Removed GlobalParams applying to suppressed parameters idaholab#8761
f2c87e2
GiudGiud added a commit to socratesgorilla/moose that referenced this issue Apr 11, 2023
@GiudGiud
Add an actual check that the suppressed parameter is not being set by…
5c9b55f 
… a global param

refs idaholab#8761
GiudGiud added a commit to socratesgorilla/moose that referenced this issue Apr 11, 2023
@GiudGiud
Do NOT set private parameters using global parameters, refs idaholab#…
4c84d7d 
…8761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@permcody permcody

@socratesgorilla socratesgorilla

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed GlobalParams applying to suppressed parameters socratesgorilla/moose
5 participants
@dschwen @permcody @YaqiWang @GiudGiud @socratesgorilla