New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ReferenceResidualProblem to a more appropriate location #9151
Comments
I'm fine with moving this, but I would much rather provide this kind of capability but in a more user-friendly way in the standard |
The problem with moving it to the misc module is that then we'd need to make the contact module depend on that, which we can do, but we try to keep module/module dependencies to a minimum. This capability really belongs in the framework. I suppose we could just move ReferenceResidualProblem as it is somewhere in framework/src/base or something. |
This came up again with @vincentlaboure...any idea when this will fully adapted or should we expect this to remain in |
I believe that this should be in the framework because it's wholly general. I would approve a PR that moved this into the framework unless others of the @idaholab/moose-team had a compelling argument not to move it. I think that |
🤘 ...after a three+ year lull, @lindsayad for the resurrection. |
I'd be in to help with setting up actions to help clean up the input, but it'd probably be better for |
Description of the enhancement or error report
Following discussions with @bwspenc and @dschwen, it seems like the
ReferenceResidualProblem
may be better suited in a more readily available spot than thecontact
module. Perhaps themisc
module? This was motivated by use ofReferenceResidualProblem
inMARMOT
, without a real need for the other pieces in thecontact
module.Rationale for the enhancement or information for reproducing the error
This will allow for easier implementation of
ReferenceResidualProblem
in other Apps.Identified impact
Users will need to couple in
misc
instead ofcontact
to useReferenceResidualProblem
(which they may already have).The text was updated successfully, but these errors were encountered: