Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReferenceResidualProblem to a more appropriate location #9151

Closed
tophmatthews opened this issue May 18, 2017 · 7 comments
Closed

Move ReferenceResidualProblem to a more appropriate location #9151

tophmatthews opened this issue May 18, 2017 · 7 comments
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@tophmatthews
Copy link
Contributor

Description of the enhancement or error report

Following discussions with @bwspenc and @dschwen, it seems like the ReferenceResidualProblem may be better suited in a more readily available spot than the contact module. Perhaps the misc module? This was motivated by use of ReferenceResidualProblem in MARMOT, without a real need for the other pieces in the contact module.

Rationale for the enhancement or information for reproducing the error

This will allow for easier implementation of ReferenceResidualProblem in other Apps.

Identified impact

Users will need to couple in misc instead of contact to use ReferenceResidualProblem (which they may already have).

@permcody permcody added C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels May 18, 2017
@bwspenc
Copy link
Contributor

bwspenc commented May 18, 2017

I'm fine with moving this, but I would much rather provide this kind of capability but in a more user-friendly way in the standard FEProblem class. Doing this in a custom Problem class was fine for the proof of concept, but this has become very widely used, and I think the usability of this is pretty awful (and I wrote it).

@tophmatthews
Copy link
Contributor Author

@bwspenc @dschwen So where are we are this? Can we have MARMOT require the contact app until someone has time to clean it up? Or should this just be moved to the misc app?

@bwspenc
Copy link
Contributor

bwspenc commented Jul 17, 2017

The problem with moving it to the misc module is that then we'd need to make the contact module depend on that, which we can do, but we try to keep module/module dependencies to a minimum.

This capability really belongs in the framework. I suppose we could just move ReferenceResidualProblem as it is somewhere in framework/src/base or something.

@tophmatthews
Copy link
Contributor Author

This came up again with @vincentlaboure...any idea when this will fully adapted or should we expect this to remain in contact @bwspenc ?

@lindsayad
Copy link
Member

I believe that this should be in the framework because it's wholly general. I would approve a PR that moved this into the framework unless others of the @idaholab/moose-team had a compelling argument not to move it. I think that ReferenceResidualProblem pairs well with automatic scaling; the former ensures that no variable is left behind in terms of converging individual non-linear residuals while the latter ensures that the Jacobian is well-conditioned. Wanting to achieve 1) convergence of all variable residuals and 2) good conditioning can be competing criteria, hence it is good to have distinct mechanisms for achieving the distinct goals.

@tophmatthews
Copy link
Contributor Author

🤘 ...after a three+ year lull, @lindsayad for the resurrection.

@tophmatthews
Copy link
Contributor Author

tophmatthews commented Aug 22, 2019

I'd be in to help with setting up actions to help clean up the input, but it'd probably be better for somewhat someone with a better knowledge of the inner FEProblem workings to give it a clean format.

lindsayad added a commit to lindsayad/moose that referenced this issue Sep 5, 2019
lindsayad added a commit to lindsayad/moose that referenced this issue Sep 6, 2019
milljm pushed a commit that referenced this issue Sep 10, 2019
milljm pushed a commit to aeslaughter/moose that referenced this issue Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

4 participants