Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogConstant time stepper #9312

Closed
agiorla opened this issue Jun 15, 2017 · 3 comments
Closed

Add LogConstant time stepper #9312

agiorla opened this issue Jun 15, 2017 · 3 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@agiorla
Copy link
Contributor

agiorla commented Jun 15, 2017

Description of the enhancement or error report

Add a TimeStepper class that would set the time step so that it remains constant in the logarithm space.

Rationale for the enhancement or information for reproducing the error

Logarithmic time steps are useful for the modeling of long-term behavior of materials or structures, notably in concrete creep or durability.

Identified impact

(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)
New TimeStepper class to add, nothing else changed.

@dschwen
Copy link
Member

dschwen commented Jun 15, 2017

@agiorla , you can already jury rig this with PostprocessorDT (using a FunctionValuePostprocessor and a ParsedFunction). But a dedicated class might not be a bad idea. I'd vote for creating an actual FunctionDT (the current one is a misnomer because it does not take a Function as an argument)

@agiorla
Copy link
Contributor Author

agiorla commented Jun 15, 2017

I've actually already written that class for a MOOSE-based application, but we thought that it might be more useful to have it directly into MOOSE instead. I'm currently in the process of reintegrating that class into MOOSE. Also, I think that it is a good idea to have that as a separate class rather than an (improved) FunctionDT, just to simplify the user's task when writing input file (no need to define an actual function) [that said, an improved FunctionDT might be a good idea, but that is probably a separate issue?]

@permcody permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Jun 15, 2017
@permcody
Copy link
Member

I guess we'll see what your class looks like when you post it. If it's a simple analytical function then we should probably just make a new/different FunctionDT. The timesteppers need to be cleaned up anyway and we have a few PRs that worked toward this but haven't been merged. One at a time is fine with me as well.

agiorla added a commit to agiorla/moose that referenced this issue Jun 15, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
agiorla added a commit to agiorla/moose that referenced this issue Jun 15, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
agiorla added a commit to agiorla/moose that referenced this issue Jun 15, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
agiorla added a commit to agiorla/moose that referenced this issue Jun 19, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
agiorla added a commit to agiorla/moose that referenced this issue Jun 19, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
jarons pushed a commit to jarons/moose that referenced this issue Oct 5, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
liuusu pushed a commit to liuusu/moose that referenced this issue Nov 13, 2017
- Added a LogConstantDT time stepper and appropriate test

closes idaholab#9312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

3 participants