Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a scalar variable explicitly and through an action should not be allowed #9313

Closed
jasondhales opened this issue Jun 15, 2017 · 2 comments
Closed

Adding a scalar variable explicitly and through an action should not be allowed #9313

jasondhales opened this issue Jun 15, 2017 · 2 comments
Assignees
@permcody
Labels
C: Framework Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@jasondhales
Copy link
Contributor

Description of the enhancement or error report

It is currently possible to add the same scalar variable explicitly and through an action. This triggers an assertion failure (at least in one case) with dbg but will run in opt. Should catch this and report an error.

Rationale for the enhancement or information for reproducing the error

Improved user experience. I have Bison input file that demonstrates this.

Identified impact

Improved user experience.
@permcody permcody added C: Framework Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Jun 15, 2017
@permcody
Copy link
Member

Actually let me clarify this a bit and make sure you agree. I don't have any problem with adding a scalar variable through an action. This should be allowed as long as it doesn't already exist in the system. I plan to provide an error message for any duplicate variable in the same system. Any objections to that?

@permcody permcody self-assigned this Jun 15, 2017
permcody added a commit to permcody/moose that referenced this issue Jun 15, 2017
@permcody
Make MOOSE error when duplicate Scalar variables are added
8216ae3 
Also error when duplicates have conflicting type
closes idaholab#9313
@permcody permcody mentioned this issue Jun 15, 2017
Merged
@jasondhales
Copy link
Contributor Author

Nope, that's perfect.

permcody added a commit to permcody/moose that referenced this issue Jun 16, 2017
@permcody
Make MOOSE error when duplicate Scalar variables are added
afd5a2d 
Also error when duplicates have conflicting type
closes idaholab#9313
permcody added a commit to permcody/moose that referenced this issue Jun 20, 2017
@permcody
Make MOOSE error when duplicate Scalar variables are added
f634f22 
Also error when duplicates have conflicting type
closes idaholab#9313
permcody added a commit to permcody/moose that referenced this issue Jun 20, 2017
@permcody
Make MOOSE error when duplicate Scalar variables are added
bee9c8e 
Also error when duplicates have conflicting type
closes idaholab#9313
jarons pushed a commit to jarons/moose that referenced this issue Oct 5, 2017
@permcody @jarons
Make MOOSE error when duplicate Scalar variables are added
27e79f5 
Also error when duplicates have conflicting type
closes idaholab#9313
liuusu pushed a commit to liuusu/moose that referenced this issue Nov 13, 2017
@permcody @liuusu
Make MOOSE error when duplicate Scalar variables are added
eb739fb 
Also error when duplicates have conflicting type
closes idaholab#9313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@permcody permcody

Labels
C: Framework Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @jasondhales