Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency resolution on Controls #9483

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Dependency resolution on Controls #9483

merged 2 commits into from
Jul 13, 2017

Conversation

andrsd
Copy link
Contributor

@andrsd andrsd commented Jul 11, 2017

This allows people to specify dependencies similarly to what we do in
MeshModifiers.

Closes #9481

@andrsd
Dependency resolution on Controls
f450d16 
This allows people to specify dependencies similarly to what we do in
MeshModifiers.

Closes idaholab#9481
@andrsd andrsd requested a review from aeslaughter July 11, 2017 22:02
@moosebuild
Copy link
Contributor

moosebuild commented Jul 11, 2017 •
edited
Loading

Job Documentation on 93143a9 wanted to post the following:

View the site here

aeslaughter
aeslaughter suggested changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@aeslaughter aeslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few tests, you should be able to use RealFunctionControl and inspect the output from "--show-controls" to check the order.

Also, a RunException test for the error would be great.

@aeslaughter aeslaughter merged commit e50bb5e into idaholab:devel Jul 13, 2017
@andrsd andrsd deleted the 9481 branch December 19, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeslaughter aeslaughter aeslaughter approved these changes

Assignees

@aeslaughter aeslaughter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrsd @moosebuild @aeslaughter