Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser stalls indefinitely for certain input files #9571

Closed
dschwen opened this issue Jul 27, 2017 · 6 comments
Closed

Parser stalls indefinitely for certain input files #9571

dschwen opened this issue Jul 27, 2017 · 6 comments
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@dschwen
Copy link
Member

dschwen commented Jul 27, 2017

Description of the enhancement or error report

Open and closing tags in variable blocks (possibly elsewhere, too) cause the parser to stall (possibly run into an infinite loop).

Rationale for the enhancement or information for reproducing the error

Minimal input to reproduce the bug:

[Variables]
  [./a][../]
[]

Identified impact

Bad behavior. Malformed input should not cause the code to stall indefinitely.

@permcody permcody added C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations. labels Jul 31, 2017
@permcody
Copy link
Member

permcody commented Aug 8, 2017

@rwcarlsen - will your parser handle this case?

@dschwen
Copy link
Member Author

dschwen commented Aug 8, 2017

For full backward compatibility it should go into an infinite loop, too.

@rwcarlsen
Copy link
Contributor

Moose (c++) parser or the python one? Also, does it loop forever in other blocks (not just Variable)? And does it still break if the closing tag is on a separate line? The new parser works.

@dschwen
Copy link
Member Author

dschwen commented Aug 9, 2017

The old C++ parser is the one that locks up. The new parser will have a common C++/python (cython) code base, right?

It does not lock up if the block closing tag is on a separate line.

@rwcarlsen
Copy link
Contributor

rwcarlsen commented Aug 9, 2017

New parser (mostly) doesn't care about whitespace. You will soon be able to have one-line input files!

We haven't fully decided if we prefer python bindings to the new c++ parser or just to have a separate but similarly architected new python parser (which I have already written) with a shared set of tests between the two.

@dschwen
Copy link
Member Author

dschwen commented Aug 9, 2017

You will soon be able to have one-line input files!

Will we have an Obfuscated MOOSE Contest as well?

rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 9, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 10, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 14, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 15, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 15, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 15, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 16, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 16, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 16, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 16, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 17, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 17, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 24, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 28, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 29, 2017
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Aug 29, 2017
jarons pushed a commit to jarons/moose that referenced this issue Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Development

No branches or pull requests

3 participants