Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting gap_geometry_type in thermal contact doesn't work #9578

Closed
bwspenc opened this issue Jul 28, 2017 · 0 comments
Closed

Setting gap_geometry_type in thermal contact doesn't work #9578

bwspenc opened this issue Jul 28, 2017 · 0 comments
Assignees
@bwspenc
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@bwspenc
Copy link
Contributor

bwspenc commented Jul 28, 2017

Description of the enhancement or error report

There's a parameter called gap_geometry_type in the ThermalContact blocks that a user can optionally set to overwrite the default behavior. In some cases, we found that the parameter was ignored.

Also, there's a related deprecated coord_type parameter in that block that needs to be removed.

Rationale for the enhancement or information for reproducing the error

For some reason, sometimes isParamSetByUser() was returning false for this parameter. This code is doing something kind of weird -- setting stuff from the parameters the first time it got run. I suspect it has something to do with that.

Identified impact

GapHeatTransfer.C, GapConductance.C
@bwspenc bwspenc self-assigned this Jul 28, 2017
bwspenc added a commit to bwspenc/moose that referenced this issue Jul 28, 2017
@bwspenc
Correctly handle user-set gap_geometry_type closes idaholab#9578
8e784ba
@bwspenc bwspenc mentioned this issue Jul 28, 2017
Merged
bwspenc added a commit to bwspenc/moose that referenced this issue Jul 28, 2017
@bwspenc
Correctly handle user-set gap_geometry_type closes idaholab#9578
568273c
@permcody permcody added C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Jul 31, 2017
jasondhales added a commit to jasondhales/moose that referenced this issue Sep 6, 2017
@jasondhales
Fix thermal contact restart bug. idaholab#9578
660a205
@jasondhales jasondhales mentioned this issue Sep 6, 2017
Merged
jasondhales added a commit to jasondhales/moose that referenced this issue Sep 7, 2017
@jasondhales
Fix thermal contact restart bug. idaholab#9578
e635bdb
jarons pushed a commit to jarons/moose that referenced this issue Oct 5, 2017
@bwspenc @jarons
Correctly handle user-set gap_geometry_type closes idaholab#9578
e2d0f59
jarons pushed a commit to jarons/moose that referenced this issue Oct 5, 2017
@jasondhales @jarons
Fix thermal contact restart bug. idaholab#9578
4f21b79
liuusu pushed a commit to liuusu/moose that referenced this issue Nov 13, 2017
@bwspenc @liuusu
Correctly handle user-set gap_geometry_type closes idaholab#9578
b01226f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwspenc bwspenc

Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @bwspenc