Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a post-processor to compute relative difference between 2 post-processors #10150

Merged

Conversation

joshuahansel
Copy link
Contributor

Added a post-processor to compute relative difference between 2 post-processors.

Closes #10148

@moosebuild
Copy link
Contributor

moosebuild commented Oct 25, 2017

Job Documentation on 8be1b6a wanted to post the following:

View the site here

This comment will be updated on new commits.

@dschwen
Copy link
Member

dschwen commented Oct 25, 2017

Linear combination, relative difference... looks like it is starting to make sense to add a ParsedPostprocessor

@permcody
Copy link
Member

Let's just jump right to ParsedKernel. In fact, we'll just let you write your weak form in a simple python script...

@YaqiWang
Copy link
Contributor

I believe I once required this ParsedPostprocessor but ended up with a ScalePostprocessor.

PostprocessorValue
RelativeDifferencePostprocessor::getValue()
{
if (std::abs(_value2) < _zero_tol)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - We coded this common operation up a long time ago:
https://github.com/idaholab/moose/blob/devel/framework/include/utils/MooseUtils.h#L213

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry - that's not the correct method. You are comparing against zero here. There are several methods in that file you might want to check out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, I will use absoluteFuzzyEqual then.

@dschwen
Copy link
Member

dschwen commented Oct 25, 2017

Let's just jump right to ParsedKernel. In fact, we'll just let you write your weak form in a simple python script...

My new function parser will actually make a parsed kernel totally possible! With actual jacobian derivation.

@joshuahansel
Copy link
Contributor Author

Let me know when Santa brings us a ParsedPostprocessor. In the end what I'd really like is a ParsedTester that works on post-processor values directly instead of going through an output file...

@andrsd andrsd merged commit b03ec4b into idaholab:devel Oct 26, 2017
@joshuahansel joshuahansel deleted the relative-difference-postprocessor branch October 26, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants