Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for getElementalValue of MooseVariableFE #11464

Merged
merged 1 commit into from May 8, 2018
Merged

Added tests for getElementalValue of MooseVariableFE #11464

merged 1 commit into from May 8, 2018

Conversation

joshuahansel
Copy link
Contributor

Refs #11451

@andrsd andrsd self-assigned this May 8, 2018
andrsd
andrsd suggested changes May 8, 2018
View reviewed changes
test/include/auxkernels/GetElementalValueAux.h Outdated
public:
GetElementalValueAux(const InputParameters & params);

virtual ~GetElementalValueAux();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we do not need empty destructors any more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, unless you are creating a new base class.

@moosebuild
Copy link
Contributor

moosebuild commented May 8, 2018 •
edited

Job Documentation on 99cce70 wanted to post the following:

View the site here

This comment will be updated on new commits.

@joshuahansel
Copy link
Contributor Author

The failed recover tests were because I used the AuxKernel on a nodal variable. I added a check in the constructor.

@joshuahansel
Copy link
Contributor Author

I can't see why the Rattlesnake failure would be related.

@andrsd
Copy link
Contributor

andrsd commented May 8, 2018

I do not think it is related to your PR.

@andrsd andrsd merged commit 077b6e0 into idaholab:devel May 8, 2018
@joshuahansel joshuahansel deleted the get-elemental-value-test branch May 9, 2018 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@permcody permcody permcody left review comments

@andrsd andrsd andrsd approved these changes

Assignees

@andrsd andrsd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshuahansel @moosebuild @andrsd @permcody