Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An attempt to implement AD for DG Kernels #12743

Merged
merged 24 commits into from Feb 22, 2019
Merged

An attempt to implement AD for DG Kernels #12743

merged 24 commits into from Feb 22, 2019

Conversation

fdkong
Copy link
Contributor

@fdkong fdkong commented Jan 22, 2019 •
edited

Starting working on AD for DG kernels

@fdkong
Copy link
Contributor Author

fdkong commented Jan 28, 2019

This now depends on #12738.

AD is working for DG Kernels now. But I would like to redesign a little bit so that we can use computeQpResidual instead of computeADQpResidual in users' code.

Create a DGKernelBase :)

@fdkong fdkong changed the title [WIP] An attempt to implement AD for DG Kernels An attempt to implement AD for DG Kernels Jan 28, 2019
@moosebuild
Copy link
Contributor

moosebuild commented Jan 28, 2019 •
edited

Job Documentation on 682fab9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@fdkong
Copy link
Contributor Author

fdkong commented Jan 31, 2019

Now, DGKernels are using computeQpResidual instead of computeADQpResidual. This change makes DGKernels consistent with anywhere else.

@fdkong
Copy link
Contributor Author

fdkong commented Jan 31, 2019

Will be going to fix all tests and add documentations.

@fdkong
Copy link
Contributor Author

fdkong commented Feb 5, 2019

Should fix the distributed mesh test

@fdkong
Copy link
Contributor Author

fdkong commented Feb 7, 2019

@lindsayad Do you think any more changes I need to make in this PR? We definitely can have more optimizations if we want.

@lindsayad
Copy link
Member

Looks like we're still waiting on removal of ADDGKernelAction. And yes I know I need to get rid of the other ADActions*...

@fdkong fdkong force-pushed the ad_dg branch 2 times, most recently from 4cc0f2a to f424988 Compare February 13, 2019 23:19
lindsayad
lindsayad requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really neat PR. Sorry I haven't reviewed sooner. See comments

framework/doc/content/source/dgkernels/ADDGDiffusion.md Outdated Show resolved Hide resolved
framework/doc/content/syntax/ADDGKernels/index.md Outdated Show resolved Hide resolved
framework/include/dgkernels/ADDGDiffusion.h Outdated Show resolved Hide resolved
framework/include/dgkernels/ADDGKernel.h Outdated Show resolved Hide resolved
framework/include/dgkernels/DGKernelBase.h Outdated Show resolved Hide resolved
framework/include/materials/TwoMaterialPropertyInterface.h Show resolved Hide resolved
framework/src/dgkernels/ADDGDiffusion.C Outdated Show resolved Hide resolved
framework/src/dgkernels/ADDGKernel.C Show resolved Hide resolved
framework/src/dgkernels/ADDGKernel.C Outdated Show resolved Hide resolved
test/tests/dgkernels/ad_dg_diffusion/tests Outdated Show resolved Hide resolved
@fdkong
Copy link
Contributor Author

fdkong commented Feb 14, 2019

@lindsayad I will address the comments ASAP.

@lindsayad
Copy link
Member

@tophmatthews see 682fab9

@aeslaughter aeslaughter merged commit 7462455 into idaholab:next Feb 22, 2019
@tophmatthews tophmatthews mentioned this pull request Feb 22, 2019
Closed
This was referenced Mar 4, 2019
Closed
Closed
@fdkong fdkong deleted the ad_dg branch August 12, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeslaughter aeslaughter aeslaughter approved these changes

@lindsayad lindsayad lindsayad approved these changes

Assignees

@lindsayad lindsayad

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fdkong @moosebuild @lindsayad @aeslaughter