Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linearized gap conductance #13242

Merged
merged 5 commits into from Apr 18, 2019

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Apr 17, 2019

This also adds a MeshGenerator that combines multiple meshes into a single unconnected mesh
(useful for setting up tests with gaps).

gold

Closes #13221

@dschwen dschwen force-pushed the linearized_gap_conductance_13221 branch from 801a800 to 36bcd56 Compare April 17, 2019 17:01
Copy link
Member

@permcody permcody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

framework/src/meshgenerators/MergedMeshGenerator.C Outdated Show resolved Hide resolved
framework/include/meshgenerators/MergedMeshGenerator.h Outdated Show resolved Hide resolved
@moosebuild
Copy link
Contributor

moosebuild commented Apr 17, 2019

Job Documentation on 1fafcdb wanted to post the following:

View the site here

This comment will be updated on new commits.

@permcody permcody added PR: Auto Merge Add this label to have CIVET merge on success and removed PR: Auto Merge Add this label to have CIVET merge on success labels Apr 17, 2019

The `MergedMeshGenerator` object allows for multiple mesh files to be "merged"
together to form a single mesh for use in a simulation. This generator will keep
all submeshes disconnected from each other. Interaction between submeshes has to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this could be used for other physics, I'd make the last sentence more general. Maybe 'Interaction between submeshes only occurs due to contact or other constraints'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, doesn't the name "Merged" sort of imply that the meshes are made to connect with each other? In Cubit, the merge command merges two adjacent bodies together to ensure that the mesh is contiguous.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree. Any suggestions for a better name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was brainstorming ideas on the way home yesterday. Here are a few I came up with:
OverlaidMeshGenerator, UnionMeshGenerator, CombineMeshGenerator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlaid implies that the meshes are on top of each other, Union and Combine are not better than Merge in my opinion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectionMeshGenerator?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with merged, but merge to me implies some sort of "joining", perhaps "stitching". I actually like Ben's suggestion of "UnionMeshGenerator" in terms of set theory. Unions bring together disjoint sets into one, which I personally find clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been renamed to MeshCollectionGenerator

modules/heat_conduction/include/materials/GapConductance.h Outdated Show resolved Hide resolved
@permcody permcody merged commit 120425a into idaholab:next Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taylor expansion of 1 / gapLength in gap conductance models
4 participants