New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linearized gap conductance #13242
Linearized gap conductance #13242
Conversation
801a800
to
36bcd56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Job Documentation on 1fafcdb wanted to post the following: View the site here This comment will be updated on new commits. |
|
||
The `MergedMeshGenerator` object allows for multiple mesh files to be "merged" | ||
together to form a single mesh for use in a simulation. This generator will keep | ||
all submeshes disconnected from each other. Interaction between submeshes has to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this could be used for other physics, I'd make the last sentence more general. Maybe 'Interaction between submeshes only occurs due to contact or other constraints'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, doesn't the name "Merged" sort of imply that the meshes are made to connect with each other? In Cubit, the merge command merges two adjacent bodies together to ensure that the mesh is contiguous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. Any suggestions for a better name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was brainstorming ideas on the way home yesterday. Here are a few I came up with:
OverlaidMeshGenerator, UnionMeshGenerator, CombineMeshGenerator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overlaid implies that the meshes are on top of each other, Union and Combine are not better than Merge in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CollectionMeshGenerator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with merged, but merge to me implies some sort of "joining", perhaps "stitching". I actually like Ben's suggestion of "UnionMeshGenerator" in terms of set theory. Unions bring together disjoint sets into one, which I personally find clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has already been renamed to MeshCollectionGenerator
dc7ed63
to
47668a2
Compare
47668a2
to
1fafcdb
Compare
This also adds a MeshGenerator that combines multiple meshes into a single unconnected mesh
(useful for setting up tests with gaps).
Closes #13221