Do coupling check for dgs and iks #13806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should also do a coupling check for objects that need more than 0 layers of ghosting like dgkernels and interfacekernels. This will also be very beneficial for applications like Rattlesnake which uses complex actions to set up their simulations. In Rattlesnake, there is often complex logic that may or may not add dgs or iks depending on the input file. Instead of always adding 1 layer of ghosting/coupling always, which is what is being currently done since the addition of coupling functors, we should just do the check for Rattlesnake and not worry about adding relationship managers from the Rattlesnake actions. By inspecting the warehouses after everything has been added, we will always get the amount of coupling needed correct, no guessing involved. Refs idaholab#13736
|
@YaqiWang I have verified that with this moose patch and after deleting the |
|
Thanks a million @lindsayad ;-) Happy coding! |
|
Job Documentation on f9cb45c wanted to post the following: View the site here This comment will be updated on new commits. |
permcody
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also do a coupling check for objects that need
more than 0 layers of ghosting like dgkernels and interfacekernels.
This will also be very beneficial for applications like Rattlesnake
which uses complex actions to set up their simulations.
In Rattlesnake, there is often complex logic that may or may not
add dgs or iks depending on the input file. Instead of always
adding 1 layer of ghosting/coupling, which is what is
being currently done from the Rattlesnake actions,
we should just do the check for Rattlesnake and not worry about
adding relationship managers from the Rattlesnake actions. By
inspecting the warehouses after everything has been added, we
will always get the amount of coupling needed correct, no guessing
involved.
Refs #13736