Fixed coupling between on/off displaced mesh #14311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @andrsd @dschwen @permcody. Quoting @andrsd
|
Here is the full error |
|
Job Documentation on 0f587fc wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Modules debug PETSc alt on 6330a08 : canceled by @permcody canceling to free up build boxes (looks like this is bad anyway) |
|
Job Modules debug PETSc submodule on 6330a08 : canceled by @permcody canceling to free up build boxes (looks like this is bad anyway) |
tophmatthews
changed the title
|
This is only to show the error. in other words, I NEED HELP TO GET THIS WORKING! |
|
Here we go again... Still need help on this! |
|
Hail mary 🏈 to @lindsayad ... this seems like something you could fix quickly? |
lindsayad
changed the title
|
@tophmatthews I've added a commit here |
tophmatthews
force-pushed
the
disp_9659
branch
from
bf991f9
to
d2dc595
Compare
|
Closer @lindsayad ! Now I get |
tophmatthews
force-pushed
the
disp_9659
branch
from
d2dc595
to
f810c64
Compare
|
Also some weird ArrayKernel diffs |
|
Try now... |
|
Yes! ... for non AD... AD still gets: but I imagine that may be a quick fix? |
If we don't we run into this issue: we call copyShapes for the jvar_number which just ends up copying in the shape functions corresponding to the basis functions for that variable. Those shape functions are calculated in the Assembly class at the beginning of element residual computation, e.g. FEProblemBase::prepare -> Assembly::reinit, entirely divorced from variable degrees of freedom. Hence the phi obtained after copyShapes absolutely will have a size even if the variable doesn't live on the undisplaced/displaced mesh
|
Looks like we're passing now... |
|
Yes! The genie came through, yet again!! You should get extra points based on how long issues have been open... |
tophmatthews
changed the title
|
This is good to go for review @permcody .... FINALLY! |
|
So, were the opt simulations screwy before this @lindsayad? Did we just get lucky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to show the inability of coupling variables that only exist on the displaced mesh, with variables that only exist on the undisplaced mesh. This fails an assert using the debug executable
Assertion 'i*j < _val.size()' failed. This has been an ongoing problem for some years now, with some false assumptions on my part that it is no longer a problem. Alas, it prevents using debug to solve problems on complex simulations, and extremely inhibits development...This was close to being fixed at one point by @andrsd and @dschwen . Perhaps this will give motivation to push it over the line!
Closes #9659