Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vector version of NaNInterface::getNaN #15136

Merged
merged 1 commit into from Apr 27, 2020
Merged

Added vector version of NaNInterface::getNaN #15136

merged 1 commit into from Apr 27, 2020

Conversation

joshuahansel
Copy link
Contributor

Refs #12234

andrsd
andrsd previously approved these changes Apr 23, 2020
View reviewed changes
@moosebuild
Copy link
Contributor

moosebuild commented Apr 23, 2020 •
edited

Job Documentation on bffd8c9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@permcody
Copy link
Member

Do we have tests for this somewhere?

@joshuahansel
Copy link
Contributor Author

We have tests for the scalar version getNaN but not the vector version. I'll add some test object(s) so that I can test the vector version.

@joshuahansel
Copy link
Contributor Author

I extended existing test objects to test the vector version.

@andrsd andrsd merged commit 5d10ab2 into idaholab:next Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrsd andrsd andrsd approved these changes

Assignees
No one assigned
Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshuahansel @moosebuild @permcody @andrsd