Unify element activation, element death and moving interface #17101
Conversation
hugary1995
force-pushed
the
subdomain_changer_pr
branch
from
4f22d3b
to
3cdb20c
Compare
|
Job Documentation on 8042a98 wanted to post the following: View the site here This comment will be updated on new commits. |
|
@fdkong @dschwen Could you please review this since you reviewed the original #16008 PR about element activation? The new UO changes some of the logic (and names of several parameters, variables, etc) in the original UO so that element activation can be generalized to element death and moving interface. The original regression tests didn't capture several parallel nodeset/sideset generation issues. I fixed those and added more regression tests. The documentation should be helpful. It also explicitly mentions what we can do with this UO. This PR will allow me to couple the element subdomain modifier with XFEM, to get smooth boundary/interface instead of the zig-zag boudaries. @bwspenc the XFEM element subdomain modifier will have to wait for this one to be merged first. |
|
What's the deal with the empty jpg files added in this PR? |
I don't know. The images are actually not empty if you check them out. I guess it's a github issue? |
|
@fdkong could you take another look at it? When I said "there is no time pressure on this" I wasn't expecting this to take two weeks. I have a report due in April. Thanks. |
Generalize the existing ActivateElementUserObjects, add ElementSubdomainModifiers, and fix some parallel bugs. close idaholab#17100
hugary1995
force-pushed
the
subdomain_changer_pr
branch
from
ff307b9
to
d5757eb
Compare
|
@fdkong I followed your suggestions and added a regression test for the steady case. |
framework/src/userobject/CoupledVarThresholdElementSubdomainModifier.C
Outdated
Show resolved
Hide resolved
|
@hugary1995 this is failing rather painfully almost everywhere in parallel: https://civet.inl.gov/event/65489/ Are you able to look into this asap or do we need to? |
|
Sure! I'll look at it ASAP! |
|
@loganharbour I can't figure it out any time soon. Can we revert it? |
|
I'll take a quick look and revert if I can't get it quickly |
Generalize the existing ActivateElementUserObjects, add ElementSubdomainModifiers, and fix some parallel bugs.
close #17100