Unify element activation, element death and moving interface #17354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize the existing ActivateElementUserObjects, add ElementSubdomainModifiers, and fix some parallel bugs. close idaholab#17100
hugary1995
commented
Mar 17, 2021
| ghost_sides_to_remove; | ||
| std::unordered_map<processor_id_type, std::vector<dof_id_type>> ghost_nodes_to_remove; | ||
|
|
||
| // The logic below updates the side set and the node set associated with the moving boundary. |
There was a problem hiding this comment.
@fdkong @dschwen @loganharbour I only changed the following logic compared to #17101 .
Here from line 172 to line 221.
As far as I can tell, the parallel issue stems from off-processor point neighbors that only shares one node with the moved element.
|
I turned on additional parallel sweeps that failed previously. Hope they pass this time! |
|
Job Documentation on 4fd85f9 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Modules Parallel on 4fd85f9 : invalidated by @fdkong TIMEOUT test:raykernels/errors.change_direction/end_set FAILED (TIMEOUT) [FINISHED] |
fdkong
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the existing ActivateElementUserObjects, add ElementSubdomainModifiers, and fix some parallel bugs.
close #17100