Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an electromagnetics module #17641

Merged
merged 250 commits into from
Jun 29, 2022
Merged

Add an electromagnetics module #17641

merged 250 commits into from
Jun 29, 2022

Conversation

cticenhour
Copy link
Member

@cticenhour cticenhour commented Apr 19, 2021 •
edited
Loading

Closes #13744

Still a few verification cases to move over and some doco to write, so marking as WIP for now.

Still to do (that I know of, as a result of testing):

  • Verify and improve coverage gaps
  • Fixup parallel and distributed failures
  • Fixup std::complex related failure (GCC?)
  • Remove sample unit tests
  • Move media into large_media
  • EM module landing page (summaries of capability, links to benchmark doco)
  • Add dissertation citation bib
  • Add comments for doxygen where missing

EDIT 5-23-2022
Relevant ELK issues in this commit history were converted to MOOSE issues. They are listed below:
#21074, #21075, #21076, #21077, #21078, #21079, #21080, #21081, #21082, #21083, #21084, #21085, #21086, #21087, #21088, #21089, #21090, #21091, #21092, #21093, #21094, #21095, #21096, #21097, #21098, #21099, #21100

EDIT 6-1-2022
Closes #21202

@cticenhour cticenhour self-assigned this Apr 19, 2021
@cticenhour
Copy link
Member Author

Tagging @skatersaurus

@cticenhour cticenhour force-pushed the electromagnetics branch 5 times, most recently from 8b8a507 to 549b66f Compare May 12, 2021 18:15
@cticenhour cticenhour force-pushed the electromagnetics branch 2 times, most recently from 809b413 to c04baf4 Compare May 17, 2021 15:18
@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale PRs that have reached or exceeded 90 days with no activity label Jul 21, 2021
@cticenhour
Copy link
Member Author

Begone stalebot

@stale stale bot removed the stale PRs that have reached or exceeded 90 days with no activity label Jul 21, 2021
@cticenhour cticenhour marked this pull request as draft July 21, 2021 17:37
@cticenhour cticenhour marked this pull request as ready for review July 26, 2021 00:00
@cticenhour cticenhour marked this pull request as draft July 26, 2021 00:15
@cticenhour cticenhour force-pushed the electromagnetics branch 2 times, most recently from fbb0202 to 5881c85 Compare September 19, 2021 18:42
@mangerij
Copy link
Contributor

Very excited for this.... we have been waiting some time :)

@cticenhour cticenhour changed the title [WIP] Add an electromagnetics module Add an electromagnetics module Oct 5, 2021
@moosebuild
Copy link
Contributor

moosebuild commented Oct 5, 2021 •
edited
Loading

Job Documentation on 5a676ee wanted to post the following:

View the site here

This comment will be updated on new commits.

@loganharbour
Copy link
Member

Job Precheck on 3443837 wanted to post the following:

Warning: This PR changes repo size by 29.02 MiB.

@cticenhour any plans on moving the bulk of this content over to large_media?

@cticenhour
Copy link
Member Author

any plans on moving the bulk of this content over to large_media?

Yes - leaving it in the branch was a convenience until I deemed this "ready for review". If this passes, one more commit to add a proper module landing page, and I'll be moving the media assets over.

cticenhour added a commit to idaholab/large_media that referenced this pull request Oct 12, 2021
@cticenhour
Add electromagnetics module media (Refs idaholab/moose#17641)
6d53c2f
@cticenhour cticenhour force-pushed the electromagnetics branch 4 times, most recently from 55e8483 to 5eb84cd Compare October 13, 2021 17:00
@cticenhour
Copy link
Member Author

Rebased on devel to test the new build env on request from @loganharbour.

@cticenhour cticenhour dismissed GiudGiud’s stale review June 23, 2022 15:24

Changes addressed

lindsayad
lindsayad previously approved these changes Jun 23, 2022
View reviewed changes
GiudGiud
GiudGiud requested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly cosmetics
I'll re-iterate that the module is exceptionally well documented, well tested, intelligently and intelligibly built.

framework/doc/content/source/kernels/FunctionDiffusion.md Outdated Show resolved Hide resolved
framework/doc/content/source/kernels/FunctionDiffusion.md Outdated Show resolved Hide resolved
framework/doc/content/source/kernels/FunctionDiffusion.md Outdated Show resolved Hide resolved
framework/doc/content/source/kernels/FunctionDiffusion.md Outdated Show resolved Hide resolved
framework/include/kernels/ADMatReaction.h Outdated Show resolved Hide resolved
modules/electromagnetics/src/kernels/VectorCurrentSource.C Outdated Show resolved Hide resolved
modules/electromagnetics/src/kernels/VectorFunctionReaction.C Outdated Show resolved Hide resolved
modules/electromagnetics/test/tests/auxkernels/current_density/tests Outdated Show resolved Hide resolved
test/tests/kernels/ad_mat_reaction/tests Outdated Show resolved Hide resolved
modules/electromagnetics/test/tests/postprocessors/reflection_coefficient/tests Show resolved Hide resolved
cticenhour added a commit to cticenhour/moose that referenced this pull request Jun 24, 2022
@cticenhour @GiudGiud
Apply suggestions from code review (idaholab#17641)
b369737 
Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
cticenhour added a commit to cticenhour/moose that referenced this pull request Jun 24, 2022
@cticenhour @GiudGiud
Apply suggestions from code review (idaholab#17641)
879ae5a 
Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
@cticenhour @GiudGiud
Apply suggestions from code review (idaholab#17641)
0a336be 
Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
@cticenhour cticenhour requested a review from GiudGiud June 24, 2022 16:23
GiudGiud
GiudGiud previously approved these changes Jun 24, 2022
View reviewed changes
@moosebuild
Copy link
Contributor

Job Precheck on 5a676ee wanted to post the following:

Warning: This PR changes repo size by 8.66 MiB.

@cticenhour
Copy link
Member Author

Thanks for the comments @loganharbour. Will make a small follow up with these changes so as not to go through testing and approvals again.

@cticenhour cticenhour merged commit d50262b into idaholab:next Jun 29, 2022
@permcody
Copy link
Member

permcody commented Jun 29, 2022 via email

@cticenhour cticenhour deleted the electromagnetics branch June 29, 2022 20:18
cticenhour added a commit to cticenhour/moose that referenced this pull request Jun 30, 2022
@cticenhour
Fixup Logan's review comments from idaholab#17641
109b24e
@cticenhour cticenhour mentioned this pull request Jun 30, 2022
Merged
cticenhour added a commit to cticenhour/moose that referenced this pull request May 30, 2023
@cticenhour
Update EM module citation (idaholab#17641)
a336bdd
tanoret pushed a commit to tanoret/moose that referenced this pull request Jul 10, 2023
@cticenhour @tanoret
Update EM module citation (idaholab#17641)
8ec1fc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangerij mangerij mangerij left review comments

@loganharbour loganharbour loganharbour approved these changes

@GiudGiud GiudGiud GiudGiud approved these changes

@lindsayad lindsayad lindsayad left review comments

@permcody permcody Awaiting requested review from permcody permcody is a code owner

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

Assignees

@cticenhour cticenhour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial Electromagnetic Eigenvalue Problems Add an electromagnetics physics module in MOOSE
7 participants
@cticenhour @mangerij @moosebuild @loganharbour @lindsayad @GiudGiud @permcody