Various NS updates for VTB support (including parsed postprocessor) #17910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moosebuild
reviewed
May 21, 2021
GiudGiud
force-pushed
the
PR_fixup_pinsfriction
branch
2 times, most recently
from
7b70d72
to
2bbe3ae
Compare
|
Job Documentation on 5dd6aec wanted to post the following: View the site here This comment will be updated on new commits. |
Fix header for non-unity build
GiudGiud
force-pushed
the
PR_fixup_pinsfriction
branch
from
2bbe3ae
to
91682fb
Compare
loganharbour
requested changes
May 22, 2021
|
Ok made the changes. I guess we can have the first people who need to do this let us know so we open it up a bit then |
GiudGiud
force-pushed
the
PR_fixup_pinsfriction
branch
from
51b9f31
to
710eec2
Compare
GiudGiud
force-pushed
the
PR_fixup_pinsfriction
branch
from
710eec2
to
3188687
Compare
GiudGiud
force-pushed
the
PR_fixup_pinsfriction
branch
from
3188687
to
ad0e944
Compare
loganharbour
requested changes
May 27, 2021
There was a problem hiding this comment.
Sorry, one last thing that was sitting around that I didn't submit.
Ping @lindsayad for the NS changes
framework/doc/content/source/postprocessors/ParsedPostprocessor.md
Outdated
Show resolved
Hide resolved
lindsayad
requested changes
May 27, 2021
modules/navier_stokes/src/fvkernels/PINSFVEnergyEffectiveDiffusion.C
Outdated
Show resolved
Hide resolved
modules/navier_stokes/test/tests/finite_volume/pins/channel-flow/2d-rc-friction.i
Show resolved
Hide resolved
Co-authored-by: Logan Harbour <loganhharbour@gmail.com> Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
|
Should be good once test pass? |
lindsayad
approved these changes
May 27, 2021
loganharbour
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17904 #17901 #3447 #5954
Needed to run the latest version of the VTB FHR model.