New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libMesh to a version with ExodusII IsoGeometric Analysis support #19222
Conversation
Job Documentation on ca4ff5e wanted to post the following: View the site here This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to newsletter
Thanks! I'll wait until after that swath of tests finishes before I push, though, just so they're not wasted and I can get a quick look at whether there's anything to worry about. (We don't have CI set up to be smart about that, do we? Only rerunning the Documentation recipe if a new commit only changes modules/doc/ ?) |
Correct. If a PR contains only markdown file changes in doc, it'll do docs only. But it isn't smart enough to see that a new commit is documentation only. With the libmesh changes, it'll all be ran. But that's fine IMO. |
Job Test timings on ca4ff5e wanted to post the following: View timings here This comment will be updated on new commits. |
Job Coverage on ca4ff5e wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReportsThis comment will be updated on new commits. |
Summary of changes: - Tri7 and Tet14 element support - Reduced Basis EIM updates - SIDE_HIERARCHIC FE support on triangles - LOG_CALL() macro - Refactored FE derivatives FDM fallback - ExodusII_IO::get_sideset_data_indices() accessor - Fix file leak/error with some ExodusII version 8 use cases - ExodusII IsoGeometric Analysis file support - Bug fixes for distcheck, clang warnings, non-double FP, Elem::permute(), etc. Refs #0
5f623b7
to
f38b3c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at first glance, only one comment. I'll take another look later at how the newsletter bit renders.
Co-authored-by: Casey Icenhour <cticenho@ncsu.edu>
All jobs on ca4ff5e : invalidated by @cticenhour Testing not triggered for some reason |
Job Valgrind electromagnetics on ca4ff5e : invalidated by @cticenhour Invalidating due to updated recipe. EM module doesn''t yet exist. |
Summary of changes:
Elem::permute(), etc.
Refs #0
Refs #18768 - this brings in read support for Exodus IGA files
Marking this as Do Not Merge at first, since there's a chance I'll want to slip in another libMesh PR first, but I'd like to at least make sure that CI here doesn't have any problem with the changes so far.