Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libMesh to a version with ExodusII IsoGeometric Analysis support #19222

Merged
merged 3 commits into from Oct 31, 2021

Conversation

roystgnr
Copy link
Contributor

Summary of changes:

  • Tri7 and Tet14 element support
  • Reduced Basis EIM updates
  • SIDE_HIERARCHIC FE support on triangles
  • LOG_CALL() macro
  • Refactored FE derivatives FDM fallback
  • ExodusII_IO::get_sideset_data_indices() accessor
  • Fix file leak/error with some ExodusII version 8 use cases
  • ExodusII IsoGeometric Analysis file support
  • Bug fixes for distcheck, clang warnings, non-double FP,
    Elem::permute(), etc.

Refs #0

Refs #18768 - this brings in read support for Exodus IGA files

Marking this as Do Not Merge at first, since there's a chance I'll want to slip in another libMesh PR first, but I'd like to at least make sure that CI here doesn't have any problem with the changes so far.

libmesh Outdated Show resolved Hide resolved
@moosebuild
Copy link
Contributor

moosebuild commented Oct 27, 2021

Job Documentation on ca4ff5e wanted to post the following:

View the site here

This comment will be updated on new commits.

Copy link
Member

@loganharbour loganharbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to newsletter

@roystgnr
Copy link
Contributor Author

Thanks! I'll wait until after that swath of tests finishes before I push, though, just so they're not wasted and I can get a quick look at whether there's anything to worry about.

(We don't have CI set up to be smart about that, do we? Only rerunning the Documentation recipe if a new commit only changes modules/doc/ ?)

@loganharbour
Copy link
Member

We don't have CI set up to be smart about that, do we?

Correct. If a PR contains only markdown file changes in doc, it'll do docs only. But it isn't smart enough to see that a new commit is documentation only. With the libmesh changes, it'll all be ran. But that's fine IMO.

@moosebuild
Copy link
Contributor

moosebuild commented Oct 27, 2021

Job Test timings on ca4ff5e wanted to post the following:

View timings here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Oct 27, 2021

Job Coverage on ca4ff5e wanted to post the following:

Framework coverage

a809cf #19222 ca4ff5
Total Total +/- New
Rate 81.83% 81.83% -0.00% -
Hits 71505 71503 -2 0
Misses 15873 15875 +2 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Summary of changes:

  - Tri7 and Tet14 element support
  - Reduced Basis EIM updates
  - SIDE_HIERARCHIC FE support on triangles
  - LOG_CALL() macro
  - Refactored FE derivatives FDM fallback
  - ExodusII_IO::get_sideset_data_indices() accessor
  - Fix file leak/error with some ExodusII version 8 use cases
  - ExodusII IsoGeometric Analysis file support
  - Bug fixes for distcheck, clang warnings, non-double FP,
    Elem::permute(), etc.

Refs #0
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, only one comment. I'll take another look later at how the newsletter bit renders.

modules/doc/content/newsletter/2021_10.md Outdated Show resolved Hide resolved
libmesh Show resolved Hide resolved
Co-authored-by: Casey Icenhour <cticenho@ncsu.edu>
@moosebuild
Copy link
Contributor

All jobs on ca4ff5e : invalidated by @cticenhour

Testing not triggered for some reason

libmesh Show resolved Hide resolved
libmesh Show resolved Hide resolved
@moosebuild
Copy link
Contributor

Job Valgrind electromagnetics on ca4ff5e : invalidated by @cticenhour

Invalidating due to updated recipe. EM module doesn''t yet exist.

@cticenhour cticenhour merged commit 7607a3f into idaholab:next Oct 31, 2021
@roystgnr roystgnr deleted the libmesh_iga_update branch November 1, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants