Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exodus IsoGeometric Analysis tests #19415

Closed
wants to merge 5 commits into from

Conversation

roystgnr
Copy link
Contributor

Reason

To help avoid regressions in the support for IsoGeometric Analysis extensions in libMesh and Moose.

Design

Two new unit tests, with IGA ExodusII files from CoreForm

Impact

No API changes here; the important code and testing framework updates went in in #19054, #19222, and #19370. I've just been delaying the unit tests while waiting to ensure that we don't expect any subsequent format changes or bug fixes to affect them.

Refs #18768, but I'm not going to say this closes that out; we could still use a couple more features and a couple more aggressive tests.

@roystgnr
Copy link
Contributor Author

Hmm... actually, one bit of long-term impact: for these tests to be useful we're going to need to add some --with-hdf5 configuration to at least some of the libMesh builds we use for CI.

@moosebuild
Copy link
Contributor

moosebuild commented Nov 16, 2021

Job Documentation on 8b6549d wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Nov 16, 2021

Job Coverage on 9b8f004 wanted to post the following:

Framework coverage

7e4878 #19415 9b8f00
Total Total +/- New
Rate 82.55% 82.56% +0.00% 87.50%
Hits 73710 73720 +10 7
Misses 15580 15578 -2 1

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 87.50% is less than the suggested 90.0%

This comment will be updated on new commits.

@roystgnr
Copy link
Contributor Author

Rebasing on top of the recent libMesh update since that hasn't hit devel yet; I'll clean up again afterwards.

@moosebuild
Copy link
Contributor

Job Precheck on 8b6549d wanted to post the following:

A change of the following file(s) triggered this check:

scripts/configure_libmesh.sh

The following file(s) are unchanged:

conda/mpich/conda_build_config.yaml
conda/libmesh/meta.yaml

The libmesh submodule or configuration was changed but the conda build config was not

@roystgnr
Copy link
Contributor Author

So ... pretty much nothing in CI loads an hdf5 module? I thought it might be getting pulled in indirectly. Good to know; I suppose I'll have to fix that there.

@roystgnr
Copy link
Contributor Author

roystgnr commented Feb 8, 2022

I just wasted too much time this afternoon because I'd forgotten that clear_spline_nodes hadn't been merged yet. If we can't get HDF5 available to CI right away (and so don't want to commit the new tests here) we'll at least need to get that first commit into its own PR.

@loganharbour
Copy link
Member

@roystgnr is this good after HDF5 is in?

@roystgnr
Copy link
Contributor Author

In between that and this we're going to want to add --enable-hdf5 to the libMesh build scripts, and I'm going to want to rebase this and make sure that CI is still happy with it and make sure CI is running the new tests.

@roystgnr
Copy link
Contributor Author

But yeah, there's nothing that needs to be added to this, just prerequisites and double-checks.

This lets us choose to load an IsoGeometric Analysis mesh without spline
nodes and spline node constraints, whether for debugging purposes or to
experiment with solver behavior or just because libMesh doesn't
parallelize those constraints efficiently enough yet.

Refs idaholab#18768
This first mesh file has no sidesets, so we'll do a transient solve, to
get a decent run with only Neumann BCs.

Refs idaholab#18768
This works for me now; let's make sure it doesn't break later.
@roystgnr
Copy link
Contributor Author

Are those current CI tests failing, or just "this branch is so old now it has atavistic tests running" failing?

@roystgnr
Copy link
Contributor Author

Closing in favor of #20646

@roystgnr roystgnr closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants