New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exodus IsoGeometric Analysis tests #19415
Conversation
Hmm... actually, one bit of long-term impact: for these tests to be useful we're going to need to add some --with-hdf5 configuration to at least some of the libMesh builds we use for CI. |
Job Documentation on 8b6549d wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on 9b8f004 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
2ac7d07
to
8796d66
Compare
Rebasing on top of the recent libMesh update since that hasn't hit devel yet; I'll clean up again afterwards. |
8796d66
to
1cab1a8
Compare
1cab1a8
to
8b6549d
Compare
Job Precheck on 8b6549d wanted to post the following: A change of the following file(s) triggered this check: scripts/configure_libmesh.sh The following file(s) are unchanged: conda/mpich/conda_build_config.yaml The libmesh submodule or configuration was changed but the conda build config was not |
8b6549d
to
3260b02
Compare
So ... pretty much nothing in CI loads an hdf5 module? I thought it might be getting pulled in indirectly. Good to know; I suppose I'll have to fix that there. |
I just wasted too much time this afternoon because I'd forgotten that clear_spline_nodes hadn't been merged yet. If we can't get HDF5 available to CI right away (and so don't want to commit the new tests here) we'll at least need to get that first commit into its own PR. |
3260b02
to
34eef6f
Compare
@roystgnr is this good after HDF5 is in? |
In between that and this we're going to want to add --enable-hdf5 to the libMesh build scripts, and I'm going to want to rebase this and make sure that CI is still happy with it and make sure CI is running the new tests. |
But yeah, there's nothing that needs to be added to this, just prerequisites and double-checks. |
cd1087e
to
758fd3d
Compare
This lets us choose to load an IsoGeometric Analysis mesh without spline nodes and spline node constraints, whether for debugging purposes or to experiment with solver behavior or just because libMesh doesn't parallelize those constraints efficiently enough yet. Refs idaholab#18768
This first mesh file has no sidesets, so we'll do a transient solve, to get a decent run with only Neumann BCs. Refs idaholab#18768
758fd3d
to
38b12f9
Compare
This works for me now; let's make sure it doesn't break later.
38b12f9
to
9b8f004
Compare
Are those current CI tests failing, or just "this branch is so old now it has atavistic tests running" failing? |
Closing in favor of #20646 |
Reason
To help avoid regressions in the support for IsoGeometric Analysis extensions in libMesh and Moose.
Design
Two new unit tests, with IGA ExodusII files from CoreForm
Impact
No API changes here; the important code and testing framework updates went in in #19054, #19222, and #19370. I've just been delaying the unit tests while waiting to ensure that we don't expect any subsequent format changes or bug fixes to affect them.
Refs #18768, but I'm not going to say this closes that out; we could still use a couple more features and a couple more aggressive tests.